From 391ebf88b7291b1ac40d8b0e446f2e928306d75b Mon Sep 17 00:00:00 2001 From: AskaEth Date: Mon, 9 Nov 2026 13:56:09 +0800 Subject: [PATCH] =?UTF-8?q?fix(ci):=20=E4=BF=AE=E4=B8=A4=E5=A4=84=20clippy?= =?UTF-8?q?=20-D=20warnings=20=E7=BA=A2=EF=BC=88needless=5Flifetimes=20/?= =?UTF-8?q?=20drain=5Fcollect=EF=BC=89?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 两处都来自 M201（5dda9ac），非本轮 mission 引入。tower 合并门此前只跑 fmt+check+test，从未跑 clippy，所以 dev 上 CI 的 clippy job 一直是红的没人发现。 - presenter/host/settings/download_tests.rs: chosen 的显式生命周期可省略 - app-iced/.../download_tests.rs: drain(..).collect() -> mem::take 语义等价，纯 lint。门禁已补上 clippy（见 00-恢复指引 §6）。 --- crates/app-iced/src/app/update/settings/download_tests.rs | 2 +- crates/presenter/src/host/settings/download_tests.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/app-iced/src/app/update/settings/download_tests.rs b/crates/app-iced/src/app/update/settings/download_tests.rs index 24a0a6d..f13b1e5 100644 --- a/crates/app-iced/src/app/update/settings/download_tests.rs +++ b/crates/app-iced/src/app/update/settings/download_tests.rs @@ -78,7 +78,7 @@ struct Hostish { impl Backend for Hostish { fn drain_events(&mut self) -> Vec { - self.queued.drain(..).collect() + std::mem::take(&mut self.queued) } fn dispatch(&mut self, command: AppCommand) { diff --git a/crates/presenter/src/host/settings/download_tests.rs b/crates/presenter/src/host/settings/download_tests.rs index 3fd7b2a..4f1dfe2 100644 --- a/crates/presenter/src/host/settings/download_tests.rs +++ b/crates/presenter/src/host/settings/download_tests.rs @@ -31,7 +31,7 @@ fn row<'a>(group: &'a SettingGroupView, key: &str) -> &'a SettingRowView { } /// 选项表里被选中的那一项（页面正是按 `selected` 下标画选中的 chip）。 -fn chosen<'a>(row: &'a SettingRowView) -> &'a str { +fn chosen(row: &SettingRowView) -> &str { row.options .get(usize::try_from(row.selected).expect("下标非负")) .map_or("<越界下标>", String::as_str)