Scoreboard/server/internal/httpapi/repo_results_test.go

package httpapi_test

import (
	"database/sql"
	"net/http"
	"strings"
	"testing"
)

// 已发布成绩不能被「存草稿」就地覆盖：ON CONFLICT 不改 state，
// 放行会把 rank 清空但流水不动，大屏奖牌与积分立刻对不上。
func TestSaveDraftRejectsPublishedResult(t *testing.T) {
	env := newTestEnv(t)
	ids := env.seed(t)
	env.createUser("recorder", "recorder-pass", "recorder")
	client, _ := env.client()
	env.login(client, "recorder", "recorder-pass")

	env.do(client, http.MethodPut, "/api/results/draft", map[string]any{
		"eventId": ids.event,
		"results": []map[string]any{
			{"entryId": ids.entryA, "resultValue": 11.58, "unit": "s", "status": "ok"},
			{"entryId": ids.entryB, "resultValue": 11.92, "unit": "s", "status": "ok"},
		},
	}, true)
	if status, env2 := env.do(client, http.MethodPost, "/api/results/publish", map[string]any{
		"eventId": ids.event,
	}, true); status != http.StatusOK {
		t.Fatalf("发布应 200，得到 %d %+v", status, env2.Error)
	}

	status, env2 := env.do(client, http.MethodPut, "/api/results/draft", map[string]any{
		"eventId": ids.event,
		"results": []map[string]any{
			{"entryId": ids.entryA, "resultValue": 12.00, "status": "ok"},
		},
	}, true)
	if status != http.StatusConflict || env2.Error == nil || env2.Error.Code != "STATE_INVALID" {
		t.Fatalf("已发布成绩存草稿应 409 STATE_INVALID，得到 %d %+v", status, env2.Error)
	}

	var (
		rank  int
		value float64
		state string
	)
	if err := env.ev.QueryRow(`SELECT rank, result_value, state FROM results WHERE entry_id = ?`, ids.entryA).
		Scan(&rank, &value, &state); err != nil {
		t.Fatalf("读取成绩: %v", err)
	}
	if rank != 1 || value != 11.58 || state != "published" {
		t.Fatalf("被拒的存草稿不得改动已发布行: rank=%d value=%v state=%s", rank, value, state)
	}

	// 正确流程：先撤销发布，再存草稿。
	if status, env2 := env.do(client, http.MethodPost, "/api/results/unpublish", map[string]any{
		"eventId": ids.event,
	}, true); status != http.StatusOK {
		t.Fatalf("撤销发布应 200，得到 %d %+v", status, env2.Error)
	}
	status, env2 = env.do(client, http.MethodPut, "/api/results/draft", map[string]any{
		"eventId": ids.event,
		"results": []map[string]any{
			{"entryId": ids.entryA, "resultValue": 12.00, "unit": "s", "status": "ok"},
		},
	}, true)
	if status != http.StatusOK || !env2.OK {
		t.Fatalf("撤销发布后存草稿应 200，得到 %d %+v", status, env2.Error)
	}
}

// 草稿未传 unit 时应保留原值，否则 100 米成绩会从 1:06.33 退化成 66.33。
func TestSaveDraftKeepsUnitWhenOmitted(t *testing.T) {
	env := newTestEnv(t)
	ids := env.seed(t)
	env.createUser("recorder", "recorder-pass", "recorder")
	client, _ := env.client()
	env.login(client, "recorder", "recorder-pass")

	env.do(client, http.MethodPut, "/api/results/draft", map[string]any{
		"eventId": ids.event,
		"results": []map[string]any{
			{"entryId": ids.entryA, "resultValue": 66.33, "unit": "s", "status": "ok"},
		},
	}, true)
	env.do(client, http.MethodPut, "/api/results/draft", map[string]any{
		"eventId": ids.event,
		"results": []map[string]any{
			{"entryId": ids.entryA, "resultValue": 66.33, "resultText": "1:06.33", "status": "ok"},
		},
	}, true)

	var unit sql.NullString
	if err := env.ev.QueryRow(`SELECT unit FROM results WHERE entry_id = ?`, ids.entryA).Scan(&unit); err != nil {
		t.Fatalf("读取单位: %v", err)
	}
	if !unit.Valid || unit.String != "s" {
		t.Fatalf("未传 unit 时应保留原值 s，得到 %+v", unit)
	}

	// 显式传 unit 仍可覆盖。
	env.do(client, http.MethodPut, "/api/results/draft", map[string]any{
		"eventId": ids.event,
		"results": []map[string]any{
			{"entryId": ids.entryA, "resultValue": 1.1, "unit": "min", "status": "ok"},
		},
	}, true)
	if err := env.ev.QueryRow(`SELECT unit FROM results WHERE entry_id = ?`, ids.entryA).Scan(&unit); err != nil {
		t.Fatalf("读取单位: %v", err)
	}
	if !unit.Valid || unit.String != "min" {
		t.Fatalf("显式传 unit 应覆盖为 min，得到 %+v", unit)
	}
}

// 手填名次只接受「不传」或「>= 1」：0 / 负数撞 results.rank 的 CHECK
// （rank IS NULL OR rank >= 1），落库才炸就是 500 + 原始约束文本，
// 录入员看到「服务端异常」根本不知道是哪一格错了。
func TestSaveDraftRejectsNonPositiveRank(t *testing.T) {
	env := newTestEnv(t)
	ids := env.seed(t)
	env.createUser("recorder", "recorder-pass", "recorder")
	client, _ := env.client()
	env.login(client, "recorder", "recorder-pass")

	for _, rank := range []int{0, -1} {
		status, env2 := env.do(client, http.MethodPut, "/api/results/draft", map[string]any{
			"eventId": ids.event,
			"results": []map[string]any{
				{"entryId": ids.entryA, "rank": rank, "resultValue": 11.58, "status": "ok"},
			},
		}, true)
		if status != http.StatusBadRequest || env2.Error == nil || env2.Error.Code != "VALIDATION_FAILED" {
			t.Fatalf("rank=%d 应 400 VALIDATION_FAILED，得到 %d %+v", rank, status, env2.Error)
		}
		if !strings.Contains(env2.Error.Message, "名次") {
			t.Fatalf("400 文案应点明「名次」与合法范围，得到 %q", env2.Error.Message)
		}
	}

	// 整批拒绝：非法名次不该把同一次请求里的其它行顺手写进去。
	if n := countRows(t, env, `SELECT COUNT(*) FROM results`); n != 0 {
		t.Fatalf("被拒的存草稿不该写库，得到 %d 条成绩", n)
	}

	// 留空（不传 rank）与 rank=1 都是合法输入，照常保存。
	status, env2 := env.do(client, http.MethodPut, "/api/results/draft", map[string]any{
		"eventId": ids.event,
		"results": []map[string]any{
			{"entryId": ids.entryA, "resultValue": 11.58, "status": "ok"},
			{"entryId": ids.entryB, "rank": 1, "resultValue": 11.92, "status": "ok"},
		},
	}, true)
	if status != http.StatusOK || !env2.OK {
		t.Fatalf("留空名次与 rank=1 应 200，得到 %d %+v", status, env2.Error)
	}
	var rank sql.NullInt64
	if err := env.ev.QueryRow(`SELECT rank FROM results WHERE entry_id = ?`, ids.entryB).Scan(&rank); err != nil {
		t.Fatalf("读名次: %v", err)
	}
	if !rank.Valid || rank.Int64 != 1 {
		t.Fatalf("rank=1 应落库，得到 %+v", rank)
	}
}