Files
Scoreboard/server/internal/rules/apply_test.go
T
AskaEth 13f1f03cd0 fix: 修掉十路审查发现的 9 个 P0 与一批 P1(数据正确性 / 越权 / 现场可用性)
P0(9 条全修):
- 多通道项目奖牌重复计数:domain 层按 (EventID,CategoryID,EntryID/Subject) 去重,
  通道优先级 athlete→team→id
- 「只排名不计分」项目(scored:false)不再进奖牌榜,REST/WS/导出口径统一
- aggregate 流水 entry_id 恒 NULL 导致重算后分数翻倍:作废范围改按 event+category 定位
- 已发布成绩仍可被「存草稿」覆盖并清空 rank:服务端 409 STATE_INVALID + 前端禁编辑
- voidResult / 规则导入重算后名次不回写:接住 Ranked 调 applyComputedRanks
- 赛事包覆盖导入可能「旧项目已删、新项目没成」:先改名成功再清理,失败回滚
- 导入赛事包可覆盖正在运行的赛事目录:name==当前项目直接 400
- Console spawn 失败后守护器永久卡死:清 child/pid + 调度重启 + stop 超时兜底
- /ws 快照向非 admin 下发 admin-only 配置:按角色裁剪 settings

P1(计分口径 / 契约 / 现场):
- standings.tieBreak 三处接线;profiles[].recordBonusMode 生效;破纪录校验
  RecordEligible 与 entry 归属;破纪录登记校验已发布成绩
- export.loadRanked 与主路径对齐;ListBackups reason 解析;CLI backup 前缀修正
  (原来只增不减会撑爆磁盘);单位积分明细/导出统一权重折算;停用单位展示
- 规则导入原子化(重算并入同一事务)+ 返回 compatible/affectedEventCount/
  recalculatedLedgerRows;登录审计 user_id 修正
- WS 策略性断开用 Close(code,reason);HelloMessage 补 page/instanceId;
  实例注册表清理;settings/单位/项目写操作补 change_log 触发大屏刷新
- 大屏:全量快照不再被版本守卫丢弃;个人积分榜刷新;公告返回页/轮播;行数截断;
  REST 竞态;1008 停止重连;握手超时;时区补 Z;401 仅 AUTH_REQUIRED 才登出
- 管理端:published 行禁编辑;saveDraft 补 unit(1:06.33 显示);前端预览改用服务端
  points;空成绩行不再恒「已修改」;修订详情按 id 拉取;切项目请求序号与 dirty 保护;
  发布后刷新项目状态;NAV/路由按角色过滤;recorder 不再打 admin-only 接口
- Console:大屏窗口销毁后重建;大屏 URL 复用 host 归一化;backup.bat 改纯 ASCII
  (已在 Meowhome 实跑验证)

自检:服务端 gofmt/build/vet 通过、12 包测试全绿;前端 vue-tsc + build 通过、
node --test 24/24;console check-syntax 12 文件通过。
2026-09-09 22:16:58 +08:00

424 lines
12 KiB
Go
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
package rules
import (
"database/sql"
"errors"
"path/filepath"
"reflect"
"testing"
"git.yeij.top/AskaEth/Scoreboard/server/internal/store"
)
const applyPackYAML = `format: scoreboard-rules
formatVersion: 1
meta: { code: demo-rules, name: 导入目标 }
standings:
individualToTeamWeight: 1
tieBreak: [points, gold, silver, bronze, teamCode]
medalCountsTeamEvents: true
showIndividualBoard: true
showIndividualMedals: true
profiles:
- code: individual_top6
name: 个人项目前六名
awardRanks: 6
tieMode: skip
rules:
- { rank: 1, points: 12 }
- { rank: 2, points: 9 }
- { rank: 3, points: 7 }
- { rank: 4, points: 4 }
- { rank: 5, points: 3 }
- { rank: 6, points: 2 }
- code: team_top6
name: 团体项目前六名
awardRanks: 6
tieMode: skip
rules:
- { rank: 1, points: 15 }
- { rank: 2, points: 10 }
- { rank: 3, points: 8 }
- { rank: 4, points: 4 }
- { rank: 5, points: 2 }
- { rank: 6, points: 1 }
- code: special_top3
name: 特别项目前三名
awardRanks: 3
tieMode: higher
rules:
- { rank: 1, points: 5 }
- { rank: 2, points: 3 }
- { rank: 3, points: 1 }
recordBonus:
enabled: false
mode: max
levels:
- { code: meet, name: 赛会纪录, points: 2 }
manualAdjustment:
enabled: false
reasonRequired: true
channelTemplates:
- match: { eventType: individual }
channels:
- { scope: athlete, basis: result, profile: individual_top6 }
- match: { eventType: team }
channels:
- { scope: team, basis: manual, profile: team_top6 }
eventOverrides:
- eventCode: EVT_IND
name: 个人示例
multiplier: 2
channels:
- { scope: athlete, basis: result, profile: individual_top6 }
- { scope: team, basis: manual, profile: team_top6 }
- eventCode: EVT_TEAM
channels: []
`
func openEventDB(t *testing.T) *sql.DB {
t.Helper()
path := filepath.Join(t.TempDir(), "event.db")
dsn := "file:" + path +
"?_pragma=journal_mode(WAL)" +
"&_pragma=foreign_keys(1)" +
"&_pragma=busy_timeout(5000)"
db, err := sql.Open("sqlite", dsn)
if err != nil {
t.Fatalf("打开赛事库: %v", err)
}
db.SetMaxOpenConns(1)
t.Cleanup(func() { _ = db.Close() })
if err := store.MigrateEvent(db); err != nil {
t.Fatalf("迁移赛事库: %v", err)
}
return db
}
// seedEvents 建一个示例大项与两个项目,并给团体项目挂一条通道,用于验证通道删除。
func seedEvents(t *testing.T, db *sql.DB) {
t.Helper()
res, err := db.Exec(`INSERT INTO sports (code, name) VALUES ('demo-sport', '示例大项')`)
if err != nil {
t.Fatalf("插入大项: %v", err)
}
sportID, err := res.LastInsertId()
if err != nil {
t.Fatalf("读取大项 id: %v", err)
}
for _, ev := range []struct {
code, name, eventType, resultType, compare string
}{
{"EVT_IND", "个人示例", "individual", "time", "asc"},
{"EVT_TEAM", "团体示例", "team", "none", "none"},
} {
if _, err := db.Exec(`INSERT INTO events (sport_id, code, name, event_type, result_type, compare, scored, multiplier)
VALUES (?, ?, ?, ?, ?, ?, 1, 1)`, sportID, ev.code, ev.name, ev.eventType, ev.resultType, ev.compare); err != nil {
t.Fatalf("插入项目 %s: %v", ev.code, err)
}
}
var teamProfileID int64
if err := db.QueryRow(`SELECT id FROM scoring_profiles WHERE code = 'team_top6'`).Scan(&teamProfileID); err != nil {
t.Fatalf("查询团体模板: %v", err)
}
var teamEventID int64
if err := db.QueryRow(`SELECT id FROM events WHERE code = 'EVT_TEAM'`).Scan(&teamEventID); err != nil {
t.Fatalf("查询团体项目: %v", err)
}
if _, err := db.Exec(`INSERT INTO event_score_channels (event_id, scope, basis, profile_id, sort_order)
VALUES (?, 'team', 'manual', ?, 0)`, teamEventID, teamProfileID); err != nil {
t.Fatalf("插入团体通道: %v", err)
}
}
func TestApplyWritesChangesAndIsIdempotent(t *testing.T) {
db := openEventDB(t)
seedEvents(t, db)
next, err := Parse([]byte(applyPackYAML))
if err != nil {
t.Fatalf("Parse: %v", err)
}
cur, err := Load(db)
if err != nil {
t.Fatalf("Load: %v", err)
}
if len(cur.Pack.Profiles) != 2 {
t.Fatalf("迁移后应有 2 个模板,实际 %d", len(cur.Pack.Profiles))
}
cs, err := Diff(cur, next)
if err != nil {
t.Fatalf("Diff: %v", err)
}
if cs.Empty() {
t.Fatal("差异不应为空")
}
// 预览阶段不落库。
if got := countRows(t, db, "scoring_profiles"); got != 2 {
t.Fatalf("Diff 不应写库,模板数 = %d", got)
}
res, err := Apply(db, cs)
if err != nil {
t.Fatalf("Apply: %v", err)
}
if res.ProfilesWritten != 3 || res.ProfilesDeleted != 0 || res.ChannelsWritten != 2 {
t.Errorf("落库统计异常: %+v", res)
}
if got := countRows(t, db, "scoring_profiles"); got != 3 {
t.Errorf("模板数 = %d,期望 3", got)
}
if got := queryFloat(t, db, `SELECT points FROM scoring_profile_rules r
JOIN scoring_profiles p ON p.id = r.profile_id WHERE p.code = 'individual_top6' AND r.rank = 1`); got != 12 {
t.Errorf("个人模板第 1 名分值 = %v,期望 12", got)
}
if got := countRows(t, db, "event_score_channels"); got != 2 {
t.Errorf("通道数 = %d,期望 2(EVT_IND 双通道、EVT_TEAM 清空)", got)
}
if got := queryInt(t, db, `SELECT COUNT(*) FROM event_score_channels c
JOIN events e ON e.id = c.event_id WHERE e.code = 'EVT_IND'`); got != 2 {
t.Errorf("EVT_IND 通道数 = %d,期望 2", got)
}
if got := queryInt(t, db, `SELECT COUNT(*) FROM event_score_channels c
JOIN events e ON e.id = c.event_id WHERE e.code = 'EVT_TEAM'`); got != 0 {
t.Errorf("EVT_TEAM 通道数 = %d,期望 0", got)
}
if got := queryFloat(t, db, `SELECT multiplier FROM events WHERE code = 'EVT_IND'`); got != 2 {
t.Errorf("EVT_IND 权重 = %v,期望 2", got)
}
if got := queryString(t, db, `SELECT value FROM settings WHERE key = 'record_bonus.levels'`); got == "" {
t.Error("破纪录档位应写入 settings")
}
// 重复导入必须幂等:第二次差异为空,Apply 不再写任何东西。
cur2, err := Load(db)
if err != nil {
t.Fatalf("再次 Load: %v", err)
}
cs2, err := Diff(cur2, next)
if err != nil {
t.Fatalf("再次 Diff: %v", err)
}
if !cs2.Empty() {
t.Fatalf("重复导入应无差异: %+v", cs2)
}
if _, err := Apply(db, cs2); err != nil {
t.Fatalf("重复 Apply: %v", err)
}
}
func TestExportRoundTripThroughDB(t *testing.T) {
db := openEventDB(t)
seedEvents(t, db)
next, err := Parse([]byte(applyPackYAML))
if err != nil {
t.Fatalf("Parse: %v", err)
}
cur, err := Load(db)
if err != nil {
t.Fatalf("Load: %v", err)
}
cs, err := Diff(cur, next)
if err != nil {
t.Fatalf("Diff: %v", err)
}
if _, err := Apply(db, cs); err != nil {
t.Fatalf("Apply: %v", err)
}
meta := Meta{Code: "demo-rules", Name: "导入目标", Version: "1.0.0", UpdatedAt: "2026-01-01", Author: "tester"}
exported, err := Export(db, meta)
if err != nil {
t.Fatalf("Export: %v", err)
}
if exported.Meta != meta {
t.Errorf("导出 meta 错误: %+v", exported.Meta)
}
if len(exported.Profiles) != 3 {
t.Fatalf("导出模板数 = %d,期望 3", len(exported.Profiles))
}
if exported.Profiles[0].Code != "individual_top6" || exported.Profiles[0].Rules[0].Points != 12 {
t.Errorf("导出模板内容错误: %+v", exported.Profiles[0])
}
var indOverride *EventOverride
for i := range exported.EventOverrides {
if exported.EventOverrides[i].EventCode == "EVT_IND" {
indOverride = &exported.EventOverrides[i]
}
}
if indOverride == nil {
t.Fatal("导出的项目例外里应包含 EVT_IND")
}
if indOverride.Multiplier == nil || *indOverride.Multiplier != 2 {
t.Errorf("EVT_IND 权重导出错误: %+v", indOverride.Multiplier)
}
if indOverride.Channels == nil || len(*indOverride.Channels) != 2 {
t.Errorf("EVT_IND 通道导出错误: %+v", indOverride.Channels)
}
raw, err := Marshal(exported)
if err != nil {
t.Fatalf("Marshal: %v", err)
}
reparsed, err := Parse(raw)
if err != nil {
t.Fatalf("重新 Parse 导出结果: %v", err)
}
if !reflect.DeepEqual(exported, reparsed) {
t.Errorf("导出结果往返不一致:\n%+v\n%+v", exported, reparsed)
}
}
// TestApplyClearsChannelsForUnscoredEvent 验证「只排名不计分」的项目导入后固定 0 通道(口径 2):
// 否则它会继承模板通道,把名次带进奖牌榜。
func TestApplyClearsChannelsForUnscoredEvent(t *testing.T) {
db := openEventDB(t)
seedEvents(t, db)
var indID, profileID int64
if err := db.QueryRow(`SELECT id FROM events WHERE code = 'EVT_IND'`).Scan(&indID); err != nil {
t.Fatalf("查询个人项目: %v", err)
}
if err := db.QueryRow(`SELECT id FROM scoring_profiles WHERE code = 'individual_top6'`).Scan(&profileID); err != nil {
t.Fatalf("查询个人模板: %v", err)
}
if _, err := db.Exec(`INSERT INTO event_score_channels (event_id, scope, basis, profile_id, sort_order)
VALUES (?, 'athlete', 'result', ?, 0)`, indID, profileID); err != nil {
t.Fatalf("插入个人通道: %v", err)
}
if _, err := db.Exec(`UPDATE events SET scored = 0 WHERE id = ?`, indID); err != nil {
t.Fatalf("关闭计分开关: %v", err)
}
next, err := Parse([]byte(applyPackYAML))
if err != nil {
t.Fatalf("Parse: %v", err)
}
cur, err := Load(db)
if err != nil {
t.Fatalf("Load: %v", err)
}
cs, err := Diff(cur, next)
if err != nil {
t.Fatalf("Diff: %v", err)
}
if _, err := Apply(db, cs); err != nil {
t.Fatalf("Apply: %v", err)
}
if got := queryInt(t, db, `SELECT COUNT(*) FROM event_score_channels c
JOIN events e ON e.id = c.event_id WHERE e.code = 'EVT_IND'`); got != 0 {
t.Fatalf("不计分项目的通道数 = %d,期望 0", got)
}
}
func TestApplyRefusesToDeleteReferencedProfile(t *testing.T) {
db := openEventDB(t)
seedEvents(t, db)
// 这份规则包没有 team_top6,而 EVT_TEAM 的通道仍引用它,删除必须被拒绝。
const packYAML = `format: scoreboard-rules
formatVersion: 1
meta: { code: demo, name: 精简规则包 }
profiles:
- code: individual_top6
name: 个人项目前六名
awardRanks: 1
tieMode: skip
rules:
- { rank: 1, points: 1 }
`
next, err := Parse([]byte(packYAML))
if err != nil {
t.Fatalf("Parse: %v", err)
}
cur, err := Load(db)
if err != nil {
t.Fatalf("Load: %v", err)
}
cs, err := Diff(cur, next)
if err != nil {
t.Fatalf("Diff: %v", err)
}
if _, err := Apply(db, cs); !errors.Is(err, ErrProfileInUse) {
t.Fatalf("期望 ErrProfileInUse,实际 %v", err)
}
if got := countRows(t, db, "scoring_profiles"); got != 2 {
t.Errorf("事务应回滚,模板数 = %d,期望 2", got)
}
}
func TestApplyNilChangeSet(t *testing.T) {
db := openEventDB(t)
if _, err := Apply(db, nil); !errors.Is(err, ErrNilChangeSet) {
t.Fatalf("期望 ErrNilChangeSet,实际 %v", err)
}
}
// 确认导入时通常只剩目标规则包(预览的 ChangeSet 不跨请求),这条路要能走通。
func TestApplyAcceptsChangeSetWithOnlyNext(t *testing.T) {
db := openEventDB(t)
next, err := Parse([]byte(applyPackYAML))
if err != nil {
t.Fatalf("Parse: %v", err)
}
res, err := Apply(db, &ChangeSet{Next: next})
if err != nil {
t.Fatalf("Apply: %v", err)
}
if res.ProfilesWritten != 3 {
t.Errorf("模板写入数 = %d,期望 3", res.ProfilesWritten)
}
if got := countRows(t, db, "scoring_profiles"); got != 3 {
t.Errorf("模板数 = %d,期望 3", got)
}
}
func countRows(t *testing.T, db *sql.DB, table string) int {
t.Helper()
var n int
if err := db.QueryRow(`SELECT COUNT(*) FROM ` + table).Scan(&n); err != nil {
t.Fatalf("统计 %s: %v", table, err)
}
return n
}
func queryInt(t *testing.T, db *sql.DB, query string) int {
t.Helper()
var n int
if err := db.QueryRow(query).Scan(&n); err != nil {
t.Fatalf("查询 %q: %v", query, err)
}
return n
}
func queryFloat(t *testing.T, db *sql.DB, query string) float64 {
t.Helper()
var v float64
if err := db.QueryRow(query).Scan(&v); err != nil {
t.Fatalf("查询 %q: %v", query, err)
}
return v
}
func queryString(t *testing.T, db *sql.DB, query string) string {
t.Helper()
var v string
if err := db.QueryRow(query).Scan(&v); err != nil {
if errors.Is(err, sql.ErrNoRows) {
return ""
}
t.Fatalf("查询 %q: %v", query, err)
}
return v
}