Files
Scoreboard/console/main/datadir.test.js
T
AskaEth 6841cf49aa fix(p2): 按审查清单修 103 条「建议修」+ 奖牌榜改名 + 两个守卫(dev_0.2.0)
## 奖牌榜改名(主人要求)
「团体奖牌榜」→「单位奖牌榜」,界面 / 大屏渲染页 / 导出件(工作表名与
下载文件名 `单位奖牌明细.xlsx`)/ 用户文档 全部统一;`DISPLAY_PAGES` 是
大屏控制页与大屏页的共同来源,改一处两边同时生效。旧名保留为别名,
老链接与老配置(`display.pages`)照常有效。真 Chromium 验证:14 个管理端
路由 + 7 个基础数据分区 0 报错,大屏页标题已是「单位奖牌榜」。

## P2 清单(123 条,103 条标「建议修」)
按 A/B/C/D 分组、以「文件所有权互斥」分 10 个代理并行推进,另有独立复核
代理逐条核对:61 条声称已修 / 55 条证实 / 4 条部分 / 0 条不成立 / 0 垃圾。

主要交付(按风险从高到低):
- 写入侧校验:update 路径补必填与 TrimSpace、模板 rules 重复 rank、
  「小项不存在」的四种回答、`defaultProfileId` 外键、decodeJSON 的 8MB
  上限与 413(A01–A06、D02、D03 批量上限 500)
- 危险操作:一键恢复加互斥(第二个请求当场 409)、恢复超时不再说
  「未执行」、`ConfirmDialog` pending 时锁死 ESC/遮罩/关闭
- 认证:改密与撤会话进同一事务、滑动续期写库失败不再假装成功、
  CSRF Cookie 丢失自动补发、密码长度按字符(原按字节)、
  反代 403 只在可信代理透传原 Host 时采信 `X-Forwarded-Host`(全等比较)、
  过期会话定期清理、登出补审计、登录限流可配
- 数据可见性:导出「已发布未结算」行改为 `名次 — / 积分 — / 状态未结算`、
  单位积分明细成绩列与其它导出件逐字一致、空单位也打合计行、
  基础数据包命中「已彻底删除的单位」整行跳过并报界面路径、
  报名导入换单位给明确提示、勾选报名有冲突不再假报成功
- 导入/导出:赛事包上限 512MB(**它是唯一带字体/图片的包**,字体上限
  20MB)而 multipart 内存档位独立钉在 16MB、工作簿表名尾随空格、
  导出件路由与文件名契约补全
- 前端:一次写请求只生成一个 requestId(幂等缓存此前从未命中)、
  基础数据包补 `X-Request-Id`、示例数据模式禁写扩到撤销发布/存草稿、
  访客 401 不再是裸错误、模板 `{{else if}}` 不再静默吞内容
- Console:按设计退出(切赛事/恢复)不再判成崩溃、旧数据目录读不出来
  会记日志、渲染层日志按上限截断、`service.js` 补 17 例测试

## 测试
服务端用例 610 → 674(13 包全绿,新增老库跨九条迁移升级、panic 形状、
429 落 interceptions、三态对照、avg_mode 分母、会话失效、请求体上限等)
前端 449 → 531(vue-tsc + build 通过);Console 28 → 54(19 个文件)。
另修复一条会让整包挂死 600s 的用例(测试主协程堵在 client.Do,defer
轮不到执行 → 改为可取消 + 探针超时,改坏也 7.5s 快速失败)。

## 两个新守卫(防止再出现「组件 setup 抛异常」这类盲区)
- `web/scripts/check-declaration-order.mjs` 已进测试命令:沿 watch/
  watchEffect 的 const 依赖链查 TDZ(正是「运动员页整块空白」的根因)
- `web/scripts/smoke-admin.mjs`(`pnpm smoke`):真 Chromium 点遍 14 个
  管理端路由 + 7 个基础数据分区 + 大屏页,任何 console 错误即失败

## 文档
- `docs/升级说明.md` 新增 dev_0.2.0 一节(三件升级必知:改名、审计前缀
  与历史记录、密码口径;现场变化;赛事包上限;反代与 CSRF)
- 使用手册 / 常见问题 / 部署指南 / 上线检查清单按实现同步
2026-09-11 23:46:59 +08:00

227 lines
8.3 KiB
JavaScript
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
'use strict'
const assert = require('node:assert/strict')
const fs = require('node:fs')
const os = require('node:os')
const path = require('node:path')
const test = require('node:test')
const { resolveDataDir, migrateLegacyData, isInside } = require('./datadir')
// 用绝对路径字符串拼测试目录,避免依赖运行平台的盘符写法
const INSTALL = path.resolve('/scoreboard-install')
const LOCAL = path.resolve('/localappdata')
function makeRoot(t) {
const root = fs.mkdtempSync(path.join(os.tmpdir(), 'scoreboard-datadir-'))
t.after(() => fs.rmSync(root, { recursive: true, force: true }))
return root
}
function writeFile(file, text) {
fs.mkdirSync(path.dirname(file), { recursive: true })
fs.writeFileSync(file, text)
}
test('打包态默认数据目录落在 %LOCALAPPDATA%\\ScoreboardConsole\\data', () => {
const info = resolveDataDir({
values: { server: { dataDir: '' } },
installDir: INSTALL,
env: { LOCALAPPDATA: LOCAL },
isPackaged: true
})
assert.equal(info.dir, path.join(LOCAL, 'ScoreboardConsole', 'data'))
assert.equal(info.source, 'localappdata')
assert.equal(info.passToServer, true)
assert.equal(isInside(INSTALL, info.dir), false)
})
test('开发态不接管数据目录,也不给服务端加 -data', () => {
const info = resolveDataDir({
values: { server: { dataDir: '' } },
installDir: INSTALL,
env: { LOCALAPPDATA: LOCAL },
isPackaged: false
})
assert.equal(info.dir, path.join(INSTALL, 'data'))
assert.equal(info.passToServer, false)
})
test('配置了绝对路径就按配置值走', () => {
const custom = path.resolve('/scoreboard-data')
const info = resolveDataDir({
values: { server: { dataDir: custom } },
installDir: INSTALL,
env: { LOCALAPPDATA: LOCAL },
isPackaged: true
})
assert.equal(info.dir, custom)
assert.equal(info.source, 'config')
assert.equal(info.passToServer, true)
})
test('配置了相对路径按安装目录解析', () => {
const info = resolveDataDir({
values: { server: { dataDir: 'data' } },
installDir: INSTALL,
env: { LOCALAPPDATA: LOCAL },
isPackaged: true
})
assert.equal(info.dir, path.join(INSTALL, 'data'))
assert.equal(info.passToServer, true)
assert.equal(isInside(INSTALL, info.dir), true)
})
test('缺 %LOCALAPPDATA% 时退回安装目录,不下发 -data', () => {
const info = resolveDataDir({
values: { server: {} },
installDir: INSTALL,
env: {},
isPackaged: true
})
assert.equal(info.dir, path.join(INSTALL, 'data'))
assert.equal(info.source, 'fallback')
assert.equal(info.passToServer, false)
})
test('目标为空且旧目录有数据 → 整体迁移', (t) => {
const root = makeRoot(t)
const legacyDir = path.join(root, 'install', 'data')
const targetDir = path.join(root, 'localappdata', 'ScoreboardConsole', 'data')
writeFile(path.join(legacyDir, 'system.db'), 'db')
writeFile(path.join(legacyDir, 'event_projs', 'default', 'event.db'), 'event')
const lines = []
const result = migrateLegacyData({ targetDir, legacyDir, log: (line) => lines.push(line) })
assert.equal(result.migrated, true)
assert.equal(result.reason, 'moved')
assert.equal(fs.existsSync(legacyDir), false)
assert.equal(fs.readFileSync(path.join(targetDir, 'system.db'), 'utf8'), 'db')
assert.equal(fs.existsSync(path.join(targetDir, 'event_projs', 'default', 'event.db')), true)
assert.match(lines.join('\n'), /已把旧数据从 .* 迁移到 /)
})
test('目标目录已存在但是空目录 → 照样迁移', (t) => {
const root = makeRoot(t)
const legacyDir = path.join(root, 'install', 'data')
const targetDir = path.join(root, 'localappdata', 'ScoreboardConsole', 'data')
writeFile(path.join(legacyDir, 'system.db'), 'db')
fs.mkdirSync(targetDir, { recursive: true })
const result = migrateLegacyData({ targetDir, legacyDir, log: () => {} })
assert.equal(result.migrated, true)
assert.equal(fs.readFileSync(path.join(targetDir, 'system.db'), 'utf8'), 'db')
assert.equal(fs.existsSync(legacyDir), false)
})
test('两边都有数据 → 不动任何一边,只记日志', (t) => {
const root = makeRoot(t)
const legacyDir = path.join(root, 'install', 'data')
const targetDir = path.join(root, 'localappdata', 'ScoreboardConsole', 'data')
writeFile(path.join(legacyDir, 'system.db'), 'old')
writeFile(path.join(targetDir, 'system.db'), 'new')
const lines = []
const result = migrateLegacyData({ targetDir, legacyDir, log: (line) => lines.push(line) })
assert.equal(result.migrated, false)
assert.equal(result.reason, 'both')
assert.equal(fs.readFileSync(path.join(legacyDir, 'system.db'), 'utf8'), 'old')
assert.equal(fs.readFileSync(path.join(targetDir, 'system.db'), 'utf8'), 'new')
assert.match(lines.join('\n'), /都有数据/)
})
test('旧目录没有数据 / 目标已有数据 / 两边同路径 → 都不动作', (t) => {
const root = makeRoot(t)
const emptyLegacy = path.join(root, 'a', 'data')
fs.mkdirSync(emptyLegacy, { recursive: true })
assert.equal(
migrateLegacyData({ targetDir: path.join(root, 'b', 'data'), legacyDir: emptyLegacy, log: () => {} }).reason,
'no-legacy'
)
assert.equal(
migrateLegacyData({ targetDir: path.join(root, 'c', 'data'), legacyDir: path.join(root, 'd', 'data'), log: () => {} }).reason,
'no-legacy'
)
const legacyDir = path.join(root, 'e', 'data')
const targetDir = path.join(root, 'f', 'data')
writeFile(path.join(targetDir, 'system.db'), 'new')
assert.equal(migrateLegacyData({ targetDir, legacyDir, log: () => {} }).reason, 'target-has-data')
assert.equal(migrateLegacyData({ targetDir, legacyDir: targetDir, log: () => {} }).reason, 'same-dir')
})
test('迁移失败时旧数据原地不动', (t) => {
const root = makeRoot(t)
// 目标目录嵌在旧目录内部,rename 必然失败(EINVAL)
const legacyDir = path.join(root, 'install', 'data')
const targetDir = path.join(legacyDir, 'nested')
writeFile(path.join(legacyDir, 'system.db'), 'db')
const lines = []
const result = migrateLegacyData({ targetDir, legacyDir, log: (line) => lines.push(line) })
assert.equal(result.migrated, false)
assert.equal(result.reason, 'failed')
assert.equal(fs.readFileSync(path.join(legacyDir, 'system.db'), 'utf8'), 'db')
assert.match(lines.join('\n'), /旧数据仍保留在/)
})
test('目标路径读不出来时按「可能有数据」处理,不做迁移', (t) => {
const root = makeRoot(t)
const legacyDir = path.join(root, 'install', 'data')
writeFile(path.join(legacyDir, 'system.db'), 'db')
// 目标目录的上级是个文件,readdir 会报 ENOTDIR
const blocker = path.join(root, 'blocker')
writeFile(blocker, 'not a dir')
const lines = []
const result = migrateLegacyData({
targetDir: path.join(blocker, 'data'),
legacyDir,
log: (line) => lines.push(line)
})
assert.equal(result.migrated, false)
assert.equal(result.reason, 'target-unreadable')
assert.equal(fs.readFileSync(path.join(legacyDir, 'system.db'), 'utf8'), 'db')
assert.match(lines.join('\n'), /跳过旧数据迁移/)
})
test('旧路径读不出来时不当成「没有旧数据」,要记一条日志', (t) => {
const root = makeRoot(t)
const targetDir = path.join(root, 'localappdata', 'ScoreboardConsole', 'data')
fs.mkdirSync(targetDir, { recursive: true })
// 旧目录的上级是个文件:readdir 报 ENOTDIR,等同于现场遇到 EACCES 这类「读不到」
const blocker = path.join(root, 'blocker')
writeFile(blocker, 'not a dir')
const lines = []
const result = migrateLegacyData({
targetDir,
legacyDir: path.join(blocker, 'data'),
log: (line) => lines.push(line)
})
assert.equal(result.migrated, false)
assert.equal(result.reason, 'legacy-unreadable')
assert.match(lines.join('\n'), /读不到旧数据目录/)
})
test('确实没有旧数据时只返回 no-legacy,不写警告日志', (t) => {
const root = makeRoot(t)
const targetDir = path.join(root, 'localappdata', 'ScoreboardConsole', 'data')
fs.mkdirSync(targetDir, { recursive: true })
const legacyDir = path.join(root, 'install', 'data')
fs.mkdirSync(legacyDir, { recursive: true })
const lines = []
const result = migrateLegacyData({ targetDir, legacyDir, log: (line) => lines.push(line) })
assert.equal(result.migrated, false)
assert.equal(result.reason, 'no-legacy')
assert.deepEqual(lines, [])
})