feat(joint-team): 联队 + 份额分成 —— 迁移 0024、引擎按份额拆、导出 / 大屏 / 录入三路打通;版本 dev_0.5.3
## 需求
现场 6 项球类比赛里,有两个单位因参赛人数不足**合并成一个单位参赛**。
做法不是新建「联队单位」(那样榜单会多出第 8 个单位,且分和奖牌分不到原单位头上),
而是**一条报名挂多个单位、按份额拆**。
## 拍板口径
- 份额**可配、默认均分**
- 积分**平均拆、接受 .5**(团体第 1 名 15 分 → 两个单位各 7.5 分)
- 奖牌**各记一枚**(两个单位各 1 枚完整金牌,不是各 0.5 枚)
- 显示上把联队名字写全(形如 `第一分公司+第二分公司联队`),成员单位的 logo 都放
- 导入表里单位编码写 `A+B`
## 一、核心层(数据模型 + 引擎 + 存储 + 报名写入 + 导入解析)
- 迁移 `0024_entry_team_shares.sql`:新建 `entry_team_shares(entry_id, team_id, points_share,
medal_share, sort_order)`。**两个口径分开表达**是刻意的——积分要拆成小数(7.5)、奖牌要整枚
各记,用一个数表达就会把「7.5 分」和「半枚金牌」绑在一起,奖牌榜立刻错。
`entries.team_id` 保留为**主单位**;老数据 `INSERT OR IGNORE` 回填成「主单位独占 100%」。
- 引擎:`ResolveShares`(引擎与读侧共用)、`splitSharePoints`(按权重归一、**末位吞余数**,
各份之和恒等于原来那一份)、`TeamShare.Medal`(缺省整枚)。积分按权重拆,奖牌每个份额各记整枚。
- 报名写入:`PUT /api/entries/{id}/team-shares`(recorder 及以上,保存后当场重算该小项组别并推榜)。
- 导入:`team_code` 支持 `A+B`(主单位 = 加号左边,均分,奖牌各整枚);非法形态
(`A+` / `+B` / `A++B` / `A+A` / 成员 >5 / 单位不存在)**行级拦下、不落库**,给人话报错。
## 二、导出与导入模板
- 11 份导出件:联队写全成员单位(`第一分公司+第二分公司联队`),并注明**分拆给了哪几家、各多少**
(份额占比 + 各单位实得积分,取自按份额拆完的流水)。
- 单位奖牌明细:奖牌格写「金牌(联队 …,各单位各记 1 枚)」;含联队时副标题说明
「各单位奖牌数之和会大于实际颁发数」——这是口径 3 的必然结果,**不是 bug**。
- 按单位筛选导出把成员单位一起算上(否则 B 单位导自己的名单会看不到自己参加的那场联队比赛)。
- 分工作表模板:`A+B` 写法挂在「单位编码」表头的**单元格批注 + 输入提示**(中英各一份);
**表头文字、列序、12 列、工作表命名一个字未动**(动了模板就导不回去)。
## 三、前端与大屏
- 录入页 / 复核页「单位」列:联队显示 `联队 第一分公司 67%(权重 2) 第二分公司 33%`,
点该格打开「成员单位与份额」弹窗(加/删成员、改权重、主单位徽标、实时比例预览)。
**普通报名(单单位)的文案、元素、类名一字未动**,只多了一个 `@click` 入口与悬停提示。
- 大屏:分项成绩 / 实时赛况单位列显示联队全名并**放上两个单位的 logo**(单位列宽按该行的
logo 数留位);底栏同理。
## 四、验证(都留了证据)
- **老数据逐字节不变**(改算分引擎的硬门槛):引擎层 golden `a2aa1c97…`、接口层 golden
`aa6cea37…`,两个哈希由主会话**在修前树上亲手重跑确认**;导出层另有 11 份导出件逐行对拍,
差异 **0 处**。
- 前端 773 → **809 例**全绿(旧用例一行未改);服务端 14 包两轮全绿;Console 68 例全绿。
- 真机联调:录入页份额弹窗、大屏两个 logo、奖牌榜 A/B 各 1 金、写路径(移除成员 → 保存 → 200)。
## 五、版本
`dev_0.5.2` → **`dev_0.5.3`**(本批含数据迁移 0024 + 新功能,必须与上一包区分开);
安装器素材重生成(版本号烙在位图里,实测只有 `brand.bmp` 的 1x/2x 两张变化,其余 92 张逐字节未变)。
This commit is contained in:
1 parent
b631418a85
commit
830a4dbdb7
61 files changed
+5649
-121
No files matched your search
@@ -129,6 +129,24 @@ type entryDTO struct {
|
||||
TeamName string `json:"teamName,omitempty"`
|
||||
ShortName *string `json:"shortName,omitempty"`
|
||||
CategoryName string `json:"categoryName,omitempty"`
|
||||
// TeamShares 是这条报名的归属份额(联队):读侧至少一条,第一条是主单位(= teamId)。
|
||||
// 普通报名也下发一条独占份额,前端不必为「有没有联队」写两套渲染。
|
||||
TeamShares []entryTeamShareDTO `json:"teamShares"`
|
||||
}
|
||||
|
||||
// entryTeamShareDTO 是报名份额的一条(联队的一个成员单位)。
|
||||
//
|
||||
// - weight:积分份额,**相对权重**(缺省 1)。引擎按权重之和归一,所以 1+1 与 0.5+0.5 等价;
|
||||
// 入库也就存原值,不做归一,避免 2:1 被写成 0.666…/0.333… 这种除不尽的数。
|
||||
// - medal :这枚奖牌是否**整枚**记给该单位(缺省 true)。联队的金牌两个单位各记 1 枚,
|
||||
// 与 weight 无关——奖牌榜数整数枚,不按积分权重拆。
|
||||
// - teamCode / teamName 是读侧补的展示字段(前端拼「A+B联队」用),写侧不需要带。
|
||||
type entryTeamShareDTO struct {
|
||||
TeamID int64 `json:"teamId"`
|
||||
Weight float64 `json:"weight"`
|
||||
Medal *bool `json:"medal,omitempty"`
|
||||
TeamCode string `json:"teamCode,omitempty"`
|
||||
TeamName string `json:"teamName,omitempty"`
|
||||
}
|
||||
|
||||
type entryWithResultDTO struct {
|
||||
|
||||
@@ -433,6 +433,56 @@ func entryTemplateHeader(language string) []string {
|
||||
return out
|
||||
}
|
||||
|
||||
// 联队(devdocs/19)怎么写,是模板必须教给填表人的事:单位编码写 `A+B`,加号左边是主单位,
|
||||
// 积分平均分、奖牌两边各记一枚。中英各一份,与表头语言一致。
|
||||
//
|
||||
// 文案只能挂在**不会变成数据的载体**上:表头行是导入器认模板的锚点(必须留在第 1 行、12 列
|
||||
// 一字不动),工作表名是「小项@组别」的范围锚点(也不能多出一张说明表,否则整份文件按分工作表
|
||||
// 口径解析时会对不上号)。所以这里用两处:单位编码表头的**单元格批注**(红三角一眼能看见)
|
||||
// 与这一列的**输入提示**(点中格子就弹出来)。
|
||||
const (
|
||||
entryJointHintZH = "单位编码怎么写:\n" +
|
||||
"· 单个单位参赛:填它的编码,例如 A。\n" +
|
||||
"· 同一小项组别里两个单位联合参赛(联队):写 A+B,加号左边那个是主单位。\n" +
|
||||
" 积分在两个单位之间平均分(各 50%,拆出 0.5 分照实记);\n" +
|
||||
" 奖牌两边各记一枚整牌——联队的金牌,A、B 各记 1 枚。"
|
||||
entryJointPromptZH = "联队写 A+B(加号左边是主单位):积分平均分,奖牌两边各记一枚"
|
||||
entryJointTitleZH = "单位编码怎么写"
|
||||
entryJointHintEN = "How to fill the team code:\n" +
|
||||
"- One unit: its code, for example A.\n" +
|
||||
"- Two units entering together as a joint team (same event and category): write A+B, " +
|
||||
"the left one is the primary unit.\n" +
|
||||
" Points are split evenly between them (50% each; halves such as 7.5 are kept as they are);\n" +
|
||||
" each unit is credited one full medal - a joint gold counts as one for A and one for B."
|
||||
entryJointPromptEN = "Joint team: write A+B (left one is the primary unit). " +
|
||||
"Points split evenly, each unit gets one full medal"
|
||||
entryJointTitleEN = "How to fill the team code"
|
||||
// entryTemplateAuthor 是批注作者。写系统名(与导出件的文档属性同一套),
|
||||
// 绝不写构建期注入的内部署名。
|
||||
entryTemplateAuthor = "赛事积分榜系统"
|
||||
// entryTemplateHintRows 是输入提示覆盖的行数:模板是空表,给填表人留够行即可。
|
||||
entryTemplateHintRows = 500
|
||||
)
|
||||
|
||||
// entryTemplateJointHint 按表头语言取「联队怎么写」的说明(批注正文 + 输入提示的标题与正文)。
|
||||
func entryTemplateJointHint(language string) (hint, title, prompt string) {
|
||||
if language == "en" {
|
||||
return entryJointHintEN, entryJointTitleEN, entryJointPromptEN
|
||||
}
|
||||
return entryJointHintZH, entryJointTitleZH, entryJointPromptZH
|
||||
}
|
||||
|
||||
// entryTeamCodeColumn 是 team_code 在表头里的列号(0 起)。模板的说明挂在这一列上,
|
||||
// 所以它从 importColumns 现算,改了列序也不会挂错格子。
|
||||
func entryTeamCodeColumn() int {
|
||||
for i, column := range importColumns {
|
||||
if column.name == "team_code" {
|
||||
return i
|
||||
}
|
||||
}
|
||||
return -1
|
||||
}
|
||||
|
||||
// entryTemplateFilename 是两种表头语言的下载文件名,前端按同一份口径拼文件名。
|
||||
func entryTemplateFilename(language string) string {
|
||||
if language == "en" {
|
||||
@@ -488,9 +538,13 @@ func (s *server) entriesTemplateXLSX(w http.ResponseWriter, r *http.Request) (an
|
||||
}
|
||||
|
||||
headers := entryTemplateHeader(language)
|
||||
hint, hintTitle, prompt := entryTemplateJointHint(language)
|
||||
sheets := make([]entriesTemplateSheet, 0, len(plan.sheets))
|
||||
for _, planned := range plan.sheets {
|
||||
sheets = append(sheets, entriesTemplateSheet{Name: planned.Name, Headers: headers})
|
||||
sheets = append(sheets, entriesTemplateSheet{
|
||||
Name: planned.Name, Headers: headers,
|
||||
JointHint: hint, JointHintTitle: hintTitle, JointPrompt: prompt,
|
||||
})
|
||||
}
|
||||
name := entryTemplateFilename(language)
|
||||
ascii := "entries-template-" + language + ".xlsx"
|
||||
@@ -518,6 +572,11 @@ func entrySheetExcludedMessage(problems []string) string {
|
||||
type entriesTemplateSheet struct {
|
||||
Name string
|
||||
Headers []string
|
||||
// JointHint / JointHintTitle / JointPrompt 是「单位编码写 A+B」的说明(按表头语言取),
|
||||
// 挂在该列的批注与输入提示上。
|
||||
JointHint string
|
||||
JointHintTitle string
|
||||
JointPrompt string
|
||||
}
|
||||
|
||||
// writeEntriesTemplateXLSX 写整份模板工作簿。
|
||||
@@ -580,6 +639,9 @@ func writeEntriesTemplateXLSX(out io.Writer, sheets []entriesTemplateSheet) erro
|
||||
if err := f.SetRowHeight(sheet.Name, 1, 24); err != nil {
|
||||
return err
|
||||
}
|
||||
if err := writeEntryJointTeamHint(f, sheet); err != nil {
|
||||
return err
|
||||
}
|
||||
// 冻结表头:一张表几十行,往下翻的时候列名得一直看得见。
|
||||
if err := f.SetPanes(sheet.Name, &excelize.Panes{
|
||||
Freeze: true, YSplit: 1, TopLeftCell: "A2", ActivePane: "bottomLeft",
|
||||
@@ -592,3 +654,45 @@ func writeEntriesTemplateXLSX(out io.Writer, sheets []entriesTemplateSheet) erro
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
// writeEntryJointTeamHint 把「联队怎么写」挂在单位编码列上:表头那一格一条批注(有红三角),
|
||||
// 整列一条输入提示(点中格子就弹出)。
|
||||
//
|
||||
// 只动这两种载体,不碰任何单元格的值与行列结构:填好的表原样传回来时,导入器读到的仍是
|
||||
// 「第 1 行 12 列表头 + 数据行」,批注与输入提示不是数据。
|
||||
func writeEntryJointTeamHint(f *excelize.File, sheet entriesTemplateSheet) error {
|
||||
column := entryTeamCodeColumn()
|
||||
if column < 0 || column >= len(sheet.Headers) || sheet.JointHint == "" {
|
||||
return nil
|
||||
}
|
||||
name, err := excelize.ColumnNumberToName(column + 1)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
if err := f.AddComment(sheet.Name, excelize.Comment{
|
||||
Cell: name + "1",
|
||||
Author: entryTemplateAuthor,
|
||||
Text: sheet.JointHint,
|
||||
Width: 360,
|
||||
Height: 170,
|
||||
}); err != nil {
|
||||
return fmt.Errorf("httpapi: 写模板批注 %s!%s1: %w", sheet.Name, name, err)
|
||||
}
|
||||
if sheet.JointPrompt == "" {
|
||||
return nil
|
||||
}
|
||||
// 刻意用 type="none":这里只要一条提示,不要任何取值限制——现场的表千奇百怪,
|
||||
// 模板不该因为一条校验规则把好好的编码挡在门外。
|
||||
dv := excelize.NewDataValidation(true)
|
||||
dv.SetSqref(fmt.Sprintf("%s2:%s%d", name, name, entryTemplateHintRows))
|
||||
dv.Type = "none"
|
||||
title := sheet.JointHintTitle
|
||||
if title == "" {
|
||||
title = "单位编码"
|
||||
}
|
||||
dv.SetInput(title, sheet.JointPrompt)
|
||||
if err := f.AddDataValidation(sheet.Name, dv); err != nil {
|
||||
return fmt.Errorf("httpapi: 写模板输入提示 %s!%s: %w", sheet.Name, name, err)
|
||||
}
|
||||
return nil
|
||||
}
|
||||
@@ -0,0 +1,421 @@
|
||||
package httpapi
|
||||
|
||||
import (
|
||||
"context"
|
||||
"database/sql"
|
||||
"fmt"
|
||||
"net/http"
|
||||
"strings"
|
||||
|
||||
"git.yeij.top/AskaEth/Scoreboard/server/internal/domain"
|
||||
"git.yeij.top/AskaEth/Scoreboard/server/internal/middleware"
|
||||
)
|
||||
|
||||
// 本文件是「联队 + 份额分成」的读写与解析(devdocs/19)。
|
||||
//
|
||||
// 表达方式:**联队是一条报名,不是一个新单位**。新建/修改报名时给多个成员单位(默认均分),
|
||||
// 分数与奖牌由引擎按份额下发到各单位;entries.team_id 仍是主单位(加号左边那个),
|
||||
// 既有查询、唯一键、榜单兜底都还认它。
|
||||
//
|
||||
// 与导入的关系:报名表的 team_code 列写 `A+B` 就是联队(默认均分),解析见 parseJointTeamCodes。
|
||||
|
||||
// maxJointTeamMembers 是联队的成员单位上限。现场最多见过三个单位合并,给到 5 已经远超需要;
|
||||
// 上限的作用是拦住「一整格都是加号」这类误填,而不是限制业务。
|
||||
const maxJointTeamMembers = 5
|
||||
|
||||
// parseJointTeamCodes 解析报名表 team_code 单元格:`A` → 单单位,`A+B` → 联队(A 是主单位)。
|
||||
//
|
||||
// 全角 + 与两侧空格都当作分隔符的一部分(现场用中文输入法填表,打出来的常是全角),
|
||||
// 但**只做这一层归一**:分段为空(`A+`、`+B`、`A++B`)、重复(`A+A`)、超长一律报错。
|
||||
// 报错必须说清「这一格该怎么写」——现场看到一句「编码非法」是没法照着改的。
|
||||
func parseJointTeamCodes(raw string) ([]string, error) {
|
||||
normalized := strings.ReplaceAll(raw, "+", "+")
|
||||
parts := strings.Split(normalized, "+")
|
||||
codes := make([]string, 0, len(parts))
|
||||
seen := make(map[string]bool, len(parts))
|
||||
for _, part := range parts {
|
||||
code := strings.TrimSpace(part)
|
||||
if code == "" {
|
||||
return nil, fmt.Errorf("单位编码 %s 里有一段是空的:联队要写成两个单位编码用 + 连起来(例如 A+B)", raw)
|
||||
}
|
||||
if seen[code] {
|
||||
return nil, fmt.Errorf("单位编码 %s 里同一个单位出现了两次:联队的每个单位只能写一次", raw)
|
||||
}
|
||||
seen[code] = true
|
||||
codes = append(codes, code)
|
||||
}
|
||||
if len(codes) > maxJointTeamMembers {
|
||||
return nil, fmt.Errorf("单位编码 %s 里写了 %d 个单位:一个联队最多 %d 个单位",
|
||||
raw, len(codes), maxJointTeamMembers)
|
||||
}
|
||||
return codes, nil
|
||||
}
|
||||
|
||||
// lookupImportTeams 把 team_code 解析成单位 id 与份额:普通报名一个单位,联队多个(默认均分)。
|
||||
//
|
||||
// 返回的份额就是写库要用的那套:每条权重 1(均分),medal 缺省(整枚各记)。
|
||||
// 主单位是 codes[0](加号左边那个),它进 entries.team_id。
|
||||
//
|
||||
// 报错都是给现场看的行级文案,不包 apiError:调用方(导入主循环)用 err.Error() 原样回显,
|
||||
// 多一层前缀现场反而看不懂。单位不存在时必须点明是联队里的哪一段,否则一行 `A+B` 里
|
||||
// 找不到 B 的时候,录入员会以为是 A 写错了。
|
||||
func (s *server) lookupImportTeams(ctx context.Context, teamCode string) ([]int64, []entryTeamShareDTO, error) {
|
||||
codes, err := parseJointTeamCodes(teamCode)
|
||||
if err != nil {
|
||||
return nil, nil, err
|
||||
}
|
||||
ids := make([]int64, 0, len(codes))
|
||||
shares := make([]entryTeamShareDTO, 0, len(codes))
|
||||
for _, code := range codes {
|
||||
id, err := s.lookupID(ctx, `SELECT id FROM teams WHERE code = ?`, code)
|
||||
if err != nil {
|
||||
if len(codes) > 1 {
|
||||
return nil, nil, fmt.Errorf("单位 %s 不存在(来自联队编码 %s)", code, teamCode)
|
||||
}
|
||||
return nil, nil, fmt.Errorf("单位 %s 不存在", code)
|
||||
}
|
||||
// 编码查单位时不排除已隐藏的(编码有唯一索引,排除会撞索引或重复建档),
|
||||
// 命中就复活他:这一行马上要给他建报名,人却看不见就说不通了。
|
||||
if err := s.reviveTeam(ctx, id); err != nil {
|
||||
return nil, nil, err
|
||||
}
|
||||
ids = append(ids, id)
|
||||
shares = append(shares, entryTeamShareDTO{TeamID: id, Weight: 1})
|
||||
}
|
||||
return ids, shares, nil
|
||||
}
|
||||
|
||||
// entryTeamSharesReady 判断份额表在不在。
|
||||
//
|
||||
// 读路径要能读「还没跑到 0024 的库」:迁移在服务启动时补跑(main.go),但榜单可能在迁移之前
|
||||
// 被读一次——0022 的老库回归用例就是在迁移前读榜的,它读的正是升级前那份错榜。
|
||||
// 表不在 = 库里没有任何联队配置 = 主单位独占 100%,正是老数据本来就该得到的结果,
|
||||
// 所以按「没有份额」处理是**精确**的,不是容错降级(份额表缺表时不可能丢掉真实配置)。
|
||||
func entryTeamSharesReady(ctx context.Context, q queryer) (bool, error) {
|
||||
var n int
|
||||
if err := q.QueryRowContext(ctx,
|
||||
`SELECT COUNT(*) FROM sqlite_master WHERE type = 'table' AND name = 'entry_team_shares'`).Scan(&n); err != nil {
|
||||
return false, err
|
||||
}
|
||||
return n != 0, nil
|
||||
}
|
||||
|
||||
// loadEntryTeamSharesQ 读一条 SQL 里给定范围内报名的份额,按 entry_id 归组。
|
||||
// eventID 为 0 表示全库(导出与快照用,与它们读 channel_ranks 的范围一致)。
|
||||
//
|
||||
// 排序按 (sort_order, team_id):主单位排第一是由写侧保证的,引擎不依赖顺序取分,
|
||||
// 但展示与流水顺序要稳定,否则同一份数据两次导出会排出两个样子。
|
||||
func loadEntryTeamSharesQ(ctx context.Context, q queryer, eventID int64) (map[int64][]domain.TeamShare, error) {
|
||||
ready, err := entryTeamSharesReady(ctx, q)
|
||||
if err != nil {
|
||||
return nil, internal(err)
|
||||
}
|
||||
if !ready {
|
||||
return nil, nil
|
||||
}
|
||||
query := `SELECT s.entry_id, s.team_id, s.points_share, s.medal_share
|
||||
FROM entry_team_shares s`
|
||||
args := []any{}
|
||||
if eventID != 0 {
|
||||
query += ` JOIN entries e ON e.id = s.entry_id WHERE e.event_id = ?`
|
||||
args = append(args, eventID)
|
||||
}
|
||||
query += ` ORDER BY s.entry_id, s.sort_order, s.team_id`
|
||||
|
||||
rows, err := q.QueryContext(ctx, query, args...)
|
||||
if err != nil {
|
||||
return nil, internal(err)
|
||||
}
|
||||
defer func() { _ = rows.Close() }()
|
||||
|
||||
out := make(map[int64][]domain.TeamShare)
|
||||
for rows.Next() {
|
||||
var (
|
||||
entryID int64
|
||||
s domain.TeamShare
|
||||
medal int
|
||||
)
|
||||
if err := rows.Scan(&entryID, &s.TeamID, &s.Weight, &medal); err != nil {
|
||||
return nil, internal(err)
|
||||
}
|
||||
if medal == 0 {
|
||||
excluded := false
|
||||
s.Medal = &excluded
|
||||
}
|
||||
out[entryID] = append(out[entryID], s)
|
||||
}
|
||||
return out, rows.Err()
|
||||
}
|
||||
|
||||
// loadEntrySharesDTOs 读某小项全部报名的份额读数形态:带上单位编码 / 名称,
|
||||
// 前端据此拼「A+B联队」,不必再查一次单位表。
|
||||
func (s *server) loadEntrySharesDTOs(ctx context.Context, q queryer, eventID int64) (map[int64][]entryTeamShareDTO, error) {
|
||||
ready, err := entryTeamSharesReady(ctx, q)
|
||||
if err != nil {
|
||||
return nil, internal(err)
|
||||
}
|
||||
if !ready {
|
||||
return nil, nil
|
||||
}
|
||||
rows, err := q.QueryContext(ctx,
|
||||
`SELECT s.entry_id, s.team_id, s.points_share, s.medal_share, t.code, t.name
|
||||
FROM entry_team_shares s
|
||||
JOIN entries e ON e.id = s.entry_id
|
||||
JOIN teams t ON t.id = s.team_id
|
||||
WHERE e.event_id = ?
|
||||
ORDER BY s.entry_id, s.sort_order, s.team_id`, eventID)
|
||||
if err != nil {
|
||||
return nil, internal(err)
|
||||
}
|
||||
defer func() { _ = rows.Close() }()
|
||||
|
||||
out := make(map[int64][]entryTeamShareDTO)
|
||||
for rows.Next() {
|
||||
var (
|
||||
entryID int64
|
||||
item entryTeamShareDTO
|
||||
medal int
|
||||
)
|
||||
if err := rows.Scan(&entryID, &item.TeamID, &item.Weight, &medal, &item.TeamCode, &item.TeamName); err != nil {
|
||||
return nil, internal(err)
|
||||
}
|
||||
if medal == 0 {
|
||||
excluded := false
|
||||
item.Medal = &excluded
|
||||
}
|
||||
out[entryID] = append(out[entryID], item)
|
||||
}
|
||||
return out, rows.Err()
|
||||
}
|
||||
|
||||
// entrySharesOf 把一条报名的份额补齐成「至少一条」:库里没有份额行时按主单位独占 100%。
|
||||
// 与引擎的 domain.ResolveShares 同口径(那边用 []domain.TeamShare,这边还要带展示字段)。
|
||||
// 主单位的编码 / 名称由调用方给(报名查询里本来就 join 了单位表)。
|
||||
func entrySharesOf(configured []entryTeamShareDTO, primaryTeamID int64, code, name string) []entryTeamShareDTO {
|
||||
if len(configured) > 0 {
|
||||
return configured
|
||||
}
|
||||
if primaryTeamID == 0 {
|
||||
return nil
|
||||
}
|
||||
return []entryTeamShareDTO{{TeamID: primaryTeamID, Weight: 1, TeamCode: code, TeamName: name}}
|
||||
}
|
||||
|
||||
// replaceEntryShares 按给定顺序重写一条报名的份额(先删后插,幂等)。
|
||||
//
|
||||
// 为什么每次都重写、而不是「有联队才写」:报名可以被改成另一个样子(联队改回单单位、
|
||||
// 换成员单位)。只增不减会留下旧份额,那条报名以后一直按早就改掉的配置分账。
|
||||
// 传空份额时按主单位独占补一条,保持「读侧至少一条」这个不变式。
|
||||
func replaceEntryShares(ctx context.Context, q queryer, entryID, primaryTeamID int64, shares []entryTeamShareDTO) error {
|
||||
if _, err := q.ExecContext(ctx, `DELETE FROM entry_team_shares WHERE entry_id = ?`, entryID); err != nil {
|
||||
return internal(err)
|
||||
}
|
||||
if len(shares) == 0 {
|
||||
shares = []entryTeamShareDTO{{TeamID: primaryTeamID, Weight: 1}}
|
||||
}
|
||||
for i, s := range shares {
|
||||
medal := 1
|
||||
if !entryShareCountsMedal(s) {
|
||||
medal = 0
|
||||
}
|
||||
if _, err := q.ExecContext(ctx,
|
||||
`INSERT INTO entry_team_shares (entry_id, team_id, points_share, medal_share, sort_order)
|
||||
VALUES (?, ?, ?, ?, ?)`,
|
||||
entryID, s.TeamID, entryShareWeight(s), medal, i); err != nil {
|
||||
return internal(err)
|
||||
}
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
// sharesContainTeam 判断份额里有没有这个单位(导入侧用它核对「主单位还在不在成员里」)。
|
||||
func sharesContainTeam(shares []entryTeamShareDTO, teamID int64) bool {
|
||||
for _, s := range shares {
|
||||
if s.TeamID == teamID {
|
||||
return true
|
||||
}
|
||||
}
|
||||
return false
|
||||
}
|
||||
|
||||
// entryShareCountsMedal 与 domain.TeamShare.CountsMedal 同一口径:缺省(nil)= 整枚各记。
|
||||
func entryShareCountsMedal(s entryTeamShareDTO) bool {
|
||||
return s.Medal == nil || *s.Medal
|
||||
}
|
||||
|
||||
// entryShareWeight 与 domain 的 shareWeight 同一口径:0(不填)按 1 处理,也就是均分。
|
||||
// 负数在 validateEntryShares 就被拦下,这里的兜底只是让写库不会撞上 CHECK。
|
||||
func entryShareWeight(s entryTeamShareDTO) float64 {
|
||||
if s.Weight <= 0 {
|
||||
return 1
|
||||
}
|
||||
return s.Weight
|
||||
}
|
||||
|
||||
// validateEntryShares 校验一次份额改动,返回给人看的 400 错误。
|
||||
//
|
||||
// 规则(每一条都对着一种会算错分的写法):
|
||||
// - 不能为空:份额为空等于没说清这条报名的分该给谁;
|
||||
// - 每个单位都得存在且没被假删除:删掉的单位不该再收分;
|
||||
// - 权重不能是负数:份额是相对权重,不填(0)就是 1——「均分」的写法,负数没有任何含义;
|
||||
// - 同一个单位只能出现一次:重复会让同一条成绩给同一个单位记两份分、两枚牌;
|
||||
// - 必须包含主单位(entries.team_id):主单位是这条报名在库里的身份(唯一键用它),
|
||||
// 把它排除在份额之外,只会得到「报名挂在 A 头上、分全给了 B」这种看不见的错。
|
||||
func (s *server) validateEntryShares(ctx context.Context, primaryTeamID int64, shares []entryTeamShareDTO) error {
|
||||
if len(shares) == 0 {
|
||||
return badRequest("teamShares 不能为空:至少要有主单位一条", nil)
|
||||
}
|
||||
if len(shares) > maxJointTeamMembers {
|
||||
return badRequest(fmt.Sprintf("teamShares 最多 %d 个单位:一个联队不需要这么多成员", maxJointTeamMembers), nil)
|
||||
}
|
||||
ids := make([]int64, 0, len(shares))
|
||||
seen := make(map[int64]bool, len(shares))
|
||||
hasPrimary := false
|
||||
for i, s := range shares {
|
||||
if s.TeamID == 0 {
|
||||
return badRequest("teamShares[].teamId 必填", i)
|
||||
}
|
||||
if seen[s.TeamID] {
|
||||
return badRequest(fmt.Sprintf("teamShares 里单位 %d 出现了两次:同一个单位只能占一份", s.TeamID), i)
|
||||
}
|
||||
seen[s.TeamID] = true
|
||||
if s.Weight < 0 {
|
||||
return badRequest(fmt.Sprintf("teamShares[].weight 不能为负数(当前 %v):份额是相对权重,不填或填 0 就按 1 算(均分)", s.Weight), i)
|
||||
}
|
||||
if s.TeamID == primaryTeamID {
|
||||
hasPrimary = true
|
||||
}
|
||||
ids = append(ids, s.TeamID)
|
||||
}
|
||||
if !hasPrimary {
|
||||
return badRequest(fmt.Sprintf("teamShares 必须包含这条报名的主单位 %d:主单位不能从份额里去掉(换主单位要重新建报名)", primaryTeamID), nil)
|
||||
}
|
||||
|
||||
args := make([]any, 0, len(ids))
|
||||
for _, id := range ids {
|
||||
args = append(args, id)
|
||||
}
|
||||
rows, err := s.ev.QueryContext(ctx,
|
||||
`SELECT id FROM teams WHERE deleted_at IS NULL AND id IN (`+placeholders(len(ids))+`)`, args...)
|
||||
if err != nil {
|
||||
return internal(err)
|
||||
}
|
||||
defer func() { _ = rows.Close() }()
|
||||
exists := make(map[int64]bool, len(ids))
|
||||
for rows.Next() {
|
||||
var id int64
|
||||
if err := rows.Scan(&id); err != nil {
|
||||
return internal(err)
|
||||
}
|
||||
exists[id] = true
|
||||
}
|
||||
if err := rows.Err(); err != nil {
|
||||
return err
|
||||
}
|
||||
missing := make([]int64, 0)
|
||||
for _, id := range ids {
|
||||
if !exists[id] {
|
||||
missing = append(missing, id)
|
||||
}
|
||||
}
|
||||
if len(missing) > 0 {
|
||||
return badRequest("teamId 不存在或已删除", missing)
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
// loadEntryForShares 读一条报名的落点(小项 / 组别 / 主单位),份额改动要用它决定重算范围。
|
||||
func (s *server) loadEntryForShares(ctx context.Context, entryID int64) (eventID, categoryID, teamID int64, err error) {
|
||||
err = s.ev.QueryRowContext(ctx,
|
||||
`SELECT event_id, category_id, team_id FROM entries WHERE id = ?`, entryID).
|
||||
Scan(&eventID, &categoryID, &teamID)
|
||||
if err == sql.ErrNoRows {
|
||||
return 0, 0, 0, notFound("报名项不存在")
|
||||
}
|
||||
if err != nil {
|
||||
return 0, 0, 0, internal(err)
|
||||
}
|
||||
return eventID, categoryID, teamID, nil
|
||||
}
|
||||
|
||||
// updateEntryTeamShares 改写一条报名的份额并重算它所在的小项组别。
|
||||
//
|
||||
// 必须重算:份额决定同一条成绩的分记在谁头上,不重算就是「界面显示改好了、榜单还是旧分」。
|
||||
// 奖牌不需要单独处理——它由读取侧按 entry_team_shares 现算,落地即生效。
|
||||
func (s *server) updateEntryTeamShares(ctx context.Context, entryID int64, shares []entryTeamShareDTO, actorID int64) (entryDTO, error) {
|
||||
eventID, categoryID, teamID, err := s.loadEntryForShares(ctx, entryID)
|
||||
if err != nil {
|
||||
return entryDTO{}, err
|
||||
}
|
||||
if err := s.validateEntryShares(ctx, teamID, shares); err != nil {
|
||||
return entryDTO{}, err
|
||||
}
|
||||
|
||||
tx, err := s.ev.BeginTx(ctx, nil)
|
||||
if err != nil {
|
||||
return entryDTO{}, internal(err)
|
||||
}
|
||||
defer func() { _ = tx.Rollback() }()
|
||||
|
||||
if err := replaceEntryShares(ctx, tx, entryID, teamID, shares); err != nil {
|
||||
return entryDTO{}, err
|
||||
}
|
||||
score, err := recomputeLedgerTx(ctx, tx, eventID, categoryID, actorID, "报名份额变更后重算")
|
||||
if err != nil {
|
||||
return entryDTO{}, err
|
||||
}
|
||||
if err := applyComputedRanks(ctx, tx, score.Ranked); err != nil {
|
||||
return entryDTO{}, err
|
||||
}
|
||||
if err := s.bumpEvent(ctx, tx, eventID); err != nil {
|
||||
return entryDTO{}, err
|
||||
}
|
||||
if err := s.bumpStandings(ctx, tx, actorID); err != nil {
|
||||
return entryDTO{}, err
|
||||
}
|
||||
if err := tx.Commit(); err != nil {
|
||||
return entryDTO{}, internal(err)
|
||||
}
|
||||
return s.getEntry(ctx, entryID)
|
||||
}
|
||||
|
||||
// getEntry 读回单条报名(含份额),供份额改写接口回显。
|
||||
func (s *server) getEntry(ctx context.Context, entryID int64) (entryDTO, error) {
|
||||
e, err := scanEntry(s.ev.QueryRowContext(ctx, entrySelect+` WHERE e.id = ?`, entryID))
|
||||
if err != nil {
|
||||
if err == sql.ErrNoRows {
|
||||
return entryDTO{}, notFound("报名项不存在")
|
||||
}
|
||||
return entryDTO{}, internal(err)
|
||||
}
|
||||
shares, err := s.loadEntrySharesDTOs(ctx, s.ev, e.EventID)
|
||||
if err != nil {
|
||||
return entryDTO{}, err
|
||||
}
|
||||
e.TeamShares = entrySharesOf(shares[e.ID], e.TeamID, e.TeamCode, e.TeamName)
|
||||
return e, nil
|
||||
}
|
||||
|
||||
// updateEntryTeamSharesHandler 是 PUT /api/entries/{id}/team-shares:
|
||||
// 改一条报名的成员单位与权重(联队),成功后返回这条报名的完整读数。
|
||||
func (s *server) updateEntryTeamSharesHandler(w http.ResponseWriter, r *http.Request) (any, error) {
|
||||
id, err := pathID(r, "id")
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
var in entryTeamSharesPayload
|
||||
if err := decodeJSON(r, &in); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
before, err := s.getEntry(r.Context(), id)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
updated, err := s.updateEntryTeamShares(r.Context(), id, in.TeamShares, middleware.User(r.Context()).ID)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
s.audit(r.Context(), "entry.team_shares.update", "entry", id,
|
||||
map[string]any{"teamShares": before.TeamShares}, map[string]any{"teamShares": updated.TeamShares})
|
||||
return updated, nil
|
||||
}
|
||||
@@ -0,0 +1,396 @@
|
||||
package httpapi_test
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"net/http"
|
||||
"strings"
|
||||
"testing"
|
||||
)
|
||||
|
||||
// 本文件钉住「联队 + 份额分成」从导入到榜单的完整链路(devdocs/19):
|
||||
// - 报名表 team_code 写 `A+B` → 一条报名挂两个单位(默认均分),主单位是加号左边那个;
|
||||
// - 团体第 1 名 15 分 → 两个单位各 7.5 分;金牌两个单位**各记 1 枚**(不是各 0.5 枚);
|
||||
// - 权重可配(2:1 → 10 / 5),改完当场重算推榜;
|
||||
// - 非法写法(单位不存在 / 缺一段 / 重复 / 太多)必须拦下并给出照得着改的报错。
|
||||
|
||||
// seedMatchEvent 造一个「球类」小项:match 类型 + 按单位录名次的团体通道
|
||||
// (规则包给 match 的模板就是 scope=team + basis=manual),返回小项与组别 id。
|
||||
func seedMatchEvent(t *testing.T, env *testEnv, ids seedIDs) (eventID, categoryID int64) {
|
||||
t.Helper()
|
||||
eventID = env.insert(t, `INSERT INTO events (sport_id, code, name, event_type, result_mode, result_type,
|
||||
compare, scored, multiplier, status)
|
||||
VALUES (?, 'BALL', '篮球', 'match', 'manual', 'count', 'none', 1, 1, 'ongoing')`, ids.sport)
|
||||
categoryID = env.insert(t, `INSERT INTO event_categories (event_id, name, multiplier, sort_order)
|
||||
VALUES (?, '男子', 1, 0)`, eventID)
|
||||
env.exec(t, `INSERT INTO event_score_channels (event_id, scope, basis, profile_id, sort_order)
|
||||
VALUES (?, 'team', 'manual', ?, 0)`, eventID, profileIDByCode(t, env, "team_top6"))
|
||||
return eventID, categoryID
|
||||
}
|
||||
|
||||
// jointImportRow 拼一行团体报名(无姓名 = 团体行),列序与 importHeader 一致。
|
||||
func jointImportRow(eventCode, category, teamCode string) string {
|
||||
return strings.Join([]string{eventCode, category, teamCode, "", "", "", "", "", "", "registered", "张伟/李强"}, ",")
|
||||
}
|
||||
|
||||
// importCSV 上传一份单表 CSV(表头 + 若干行)。
|
||||
func importCSV(t *testing.T, env *testEnv, client *http.Client, rows ...string) (int, envelope) {
|
||||
t.Helper()
|
||||
content := importHeader + "\n" + strings.Join(rows, "\n") + "\n"
|
||||
return env.postImport(t, client, "/api/entries/import", content, "")
|
||||
}
|
||||
|
||||
// sharesDump 导出某小项「报名 + 份额」的原始落库事实(列序见下面的查询):
|
||||
// share_team 为 "<nil>" 表示这条报名一条份额都没有(不该出现)。
|
||||
func sharesDump(t *testing.T, env *testEnv, eventID int64) string {
|
||||
t.Helper()
|
||||
return tableDump(t, env, fmt.Sprintf(
|
||||
`SELECT e.id AS entry_id, COALESCE(e.athlete_id, 0) AS athlete_id, e.team_id,
|
||||
COALESCE(s.team_id, 0) AS share_team, COALESCE(s.points_share, 0) AS points_share,
|
||||
COALESCE(s.medal_share, 0) AS medal_share, COALESCE(s.sort_order, 0) AS sort_order
|
||||
FROM entries e
|
||||
LEFT JOIN entry_team_shares s ON s.entry_id = e.id
|
||||
WHERE e.event_id = %d
|
||||
ORDER BY e.id, s.sort_order, s.team_id`, eventID))
|
||||
}
|
||||
|
||||
// shareRow 按 tableDump 的格式拼一行份额(列名=值,行尾一个空格)。
|
||||
func shareRow(entryID, athleteID, teamID, shareTeam int64, weight float64, medal, order int) string {
|
||||
return fmt.Sprintf("entry_id=%d athlete_id=%d team_id=%d share_team=%d points_share=%v medal_share=%d sort_order=%d \n",
|
||||
entryID, athleteID, teamID, shareTeam, weight, medal, order)
|
||||
}
|
||||
|
||||
// shareAbsentRow 是「这条报名一条份额行都没有」的 dump 行:种子 / 手工造的报名直接写 entries,
|
||||
// 绕过了导入,库里就没有份额行——读侧与引擎都按主单位独占 100% 兜底(老数据同理)。
|
||||
func shareAbsentRow(entryID, athleteID, teamID int64) string {
|
||||
return fmt.Sprintf("entry_id=%d athlete_id=%d team_id=%d share_team=0 points_share=0 medal_share=0 sort_order=0 \n",
|
||||
entryID, athleteID, teamID)
|
||||
}
|
||||
|
||||
// firstEntryID 取某小项的第一条报名 id。
|
||||
func firstEntryID(t *testing.T, env *testEnv, eventID int64) int64 {
|
||||
t.Helper()
|
||||
var id int64
|
||||
if err := env.ev.QueryRow(`SELECT id FROM entries WHERE event_id = ? ORDER BY id LIMIT 1`, eventID).Scan(&id); err != nil {
|
||||
t.Fatalf("读报名项: %v", err)
|
||||
}
|
||||
return id
|
||||
}
|
||||
|
||||
// standingsRow 取积分榜上某个单位那一行(REST /api/standings 的原始读数)。
|
||||
func standingsRow(t *testing.T, env *testEnv, client *http.Client, teamID int64) map[string]any {
|
||||
t.Helper()
|
||||
status, resp := env.do(client, http.MethodGet, "/api/standings", nil, false)
|
||||
if status != http.StatusOK || !resp.OK {
|
||||
t.Fatalf("读积分榜应 200,得到 %d %+v", status, resp.Error)
|
||||
}
|
||||
for _, row := range decodeData[[]map[string]any](t, resp) {
|
||||
if row["teamId"] == float64(teamID) {
|
||||
return row
|
||||
}
|
||||
}
|
||||
t.Fatalf("积分榜上没有单位 %d", teamID)
|
||||
return nil
|
||||
}
|
||||
|
||||
// assertStanding 断言某单位的总分与金银铜。
|
||||
func assertStanding(t *testing.T, env *testEnv, client *http.Client, teamID int64, points float64, gold, silver, bronze int) {
|
||||
t.Helper()
|
||||
row := standingsRow(t, env, client, teamID)
|
||||
if got := row["totalPoints"].(float64); got != points {
|
||||
t.Errorf("单位 %d 总分 = %v,期望 %v(整行:%+v)", teamID, got, points, row)
|
||||
}
|
||||
for name, want := range map[string]int{"gold": gold, "silver": silver, "bronze": bronze} {
|
||||
if got := row[name].(float64); got != float64(want) {
|
||||
t.Errorf("单位 %d 的 %s = %v,期望 %d(整行:%+v)", teamID, name, got, want, row)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// 现场场景:两个单位因人数不足合并参赛,团体第 1 名 15 分 → A、B 各 7.5 分、各 1 枚金牌。
|
||||
func TestImportJointTeamSplitsPointsAndMedals(t *testing.T) {
|
||||
env, ids, client := recorderWithSeed(t)
|
||||
eventID, categoryID := seedMatchEvent(t, env, ids)
|
||||
|
||||
status, resp := importCSV(t, env, client, jointImportRow("BALL", "男子", "A+B"))
|
||||
if status != http.StatusOK || !resp.OK {
|
||||
t.Fatalf("导入联队报名应 200,得到 %d %+v", status, resp.Error)
|
||||
}
|
||||
if result := decodeData[map[string]any](t, resp); result["created"].(float64) != 1 {
|
||||
t.Fatalf("应新建 1 条报名,得到 %+v", result)
|
||||
}
|
||||
|
||||
// 主单位是加号左边那个(A),份额表里两条均分、奖牌各记整枚。
|
||||
entryID := firstEntryID(t, env, eventID)
|
||||
want := shareRow(entryID, 0, ids.teamA, ids.teamA, 1, 1, 0) +
|
||||
shareRow(entryID, 0, ids.teamA, ids.teamB, 1, 1, 1)
|
||||
if got := sharesDump(t, env, eventID); got != want {
|
||||
t.Fatalf("联队报名落库不对:\n得到 %s期望 %s", got, want)
|
||||
}
|
||||
|
||||
// 团体名次录在主单位上(现场就是按单位录名次):联队第 1 名。
|
||||
if status, resp := putTeamRanks(t, env, client, eventID, categoryID, []map[string]any{
|
||||
{"teamId": ids.teamA, "rank": 1},
|
||||
}); status != http.StatusOK {
|
||||
t.Fatalf("录团体名次应 200,得到 %d %+v", status, resp.Error)
|
||||
}
|
||||
|
||||
// 积分各 7.5(允许出现小数),金牌各 1 枚。
|
||||
assertStanding(t, env, client, ids.teamA, 7.5, 1, 0, 0)
|
||||
assertStanding(t, env, client, ids.teamB, 7.5, 1, 0, 0)
|
||||
|
||||
ledger := tableDump(t, env, `SELECT team_id, points FROM score_ledger WHERE voided = 0 ORDER BY team_id`)
|
||||
wantLedger := fmt.Sprintf("team_id=%d points=7.5 \nteam_id=%d points=7.5 \n", ids.teamA, ids.teamB)
|
||||
if ledger != wantLedger {
|
||||
t.Fatalf("积分流水应按份额拆成两条:\n得到 %s期望 %s", ledger, wantLedger)
|
||||
}
|
||||
}
|
||||
|
||||
// 权重可配:改成 2:1 → 10 / 5;奖牌仍是各 1 枚(两个口径互不影响)。
|
||||
func TestUpdateEntryTeamSharesWeights(t *testing.T) {
|
||||
env, ids, client := recorderWithSeed(t)
|
||||
eventID, categoryID := seedMatchEvent(t, env, ids)
|
||||
if status, resp := importCSV(t, env, client, jointImportRow("BALL", "男子", "A+B")); status != http.StatusOK {
|
||||
t.Fatalf("导入联队报名应 200,得到 %d %+v", status, resp.Error)
|
||||
}
|
||||
entryID := firstEntryID(t, env, eventID)
|
||||
if status, resp := putTeamRanks(t, env, client, eventID, categoryID, []map[string]any{
|
||||
{"teamId": ids.teamA, "rank": 1},
|
||||
}); status != http.StatusOK {
|
||||
t.Fatalf("录团体名次应 200,得到 %d %+v", status, resp.Error)
|
||||
}
|
||||
assertStanding(t, env, client, ids.teamA, 7.5, 1, 0, 0)
|
||||
|
||||
path := fmt.Sprintf("/api/entries/%d/team-shares", entryID)
|
||||
status, resp := env.do(client, http.MethodPut, path, map[string]any{
|
||||
"teamShares": []map[string]any{
|
||||
{"teamId": ids.teamA, "weight": 2},
|
||||
{"teamId": ids.teamB, "weight": 1},
|
||||
},
|
||||
}, true)
|
||||
if status != http.StatusOK || !resp.OK {
|
||||
t.Fatalf("改份额应 200,得到 %d %+v", status, resp.Error)
|
||||
}
|
||||
updated := decodeData[map[string]any](t, resp)
|
||||
shares, _ := updated["teamShares"].([]any)
|
||||
if len(shares) != 2 {
|
||||
t.Fatalf("回显应带两条份额,得到 %+v", updated["teamShares"])
|
||||
}
|
||||
first, _ := shares[0].(map[string]any)
|
||||
if first["teamId"] != float64(ids.teamA) || first["weight"] != float64(2) {
|
||||
t.Fatalf("回显的第一条应是主单位 A 权重 2,得到 %+v", first)
|
||||
}
|
||||
if first["teamCode"] != "A" || first["teamName"] != "第一分公司" {
|
||||
t.Fatalf("回显应带上单位编码与名称(前端拼「A+B联队」用),得到 %+v", first)
|
||||
}
|
||||
|
||||
// 改完当场重算:2:1 拆成 10 / 5,奖牌不受权重影响,仍是各 1 枚。
|
||||
assertStanding(t, env, client, ids.teamA, 10, 1, 0, 0)
|
||||
assertStanding(t, env, client, ids.teamB, 5, 1, 0, 0)
|
||||
|
||||
// 奖牌开关按单位存(medal=false 落成 medal_share=0 再读回来),积分照旧按权重拆。
|
||||
status, resp = env.do(client, http.MethodPut, path, map[string]any{
|
||||
"teamShares": []map[string]any{
|
||||
{"teamId": ids.teamA, "weight": 2},
|
||||
{"teamId": ids.teamB, "weight": 1, "medal": false},
|
||||
},
|
||||
}, true)
|
||||
if status != http.StatusOK || !resp.OK {
|
||||
t.Fatalf("关掉成员单位的奖牌应 200,得到 %d %+v", status, resp.Error)
|
||||
}
|
||||
shares, _ = decodeData[map[string]any](t, resp)["teamShares"].([]any)
|
||||
second, _ := shares[1].(map[string]any)
|
||||
if second["medal"] != false {
|
||||
t.Fatalf("回显应带上「这个单位不记奖牌」(medal:false),得到 %+v", second)
|
||||
}
|
||||
assertStanding(t, env, client, ids.teamA, 10, 1, 0, 0)
|
||||
assertStanding(t, env, client, ids.teamB, 5, 0, 0, 0)
|
||||
}
|
||||
|
||||
// 非法份额的报错必须说清怎么改(人话),且一律不落库。
|
||||
func TestUpdateEntryTeamSharesRejectsBadPayloads(t *testing.T) {
|
||||
env, ids, client := recorderWithSeed(t)
|
||||
eventID, _ := seedMatchEvent(t, env, ids)
|
||||
if status, resp := importCSV(t, env, client, jointImportRow("BALL", "男子", "A")); status != http.StatusOK {
|
||||
t.Fatalf("导入单人报名应 200,得到 %d %+v", status, resp.Error)
|
||||
}
|
||||
entryID := firstEntryID(t, env, eventID)
|
||||
path := fmt.Sprintf("/api/entries/%d/team-shares", entryID)
|
||||
baseline := tableDump(t, env, `SELECT team_id, points_share FROM entry_team_shares ORDER BY team_id`)
|
||||
|
||||
cases := []struct {
|
||||
name string
|
||||
body map[string]any
|
||||
want string
|
||||
}{
|
||||
{"空份额", map[string]any{"teamShares": []map[string]any{}}, "teamShares 不能为空"},
|
||||
{"缺主单位", map[string]any{"teamShares": []map[string]any{{"teamId": ids.teamB}}}, "必须包含这条报名的主单位"},
|
||||
{"单位重复", map[string]any{"teamShares": []map[string]any{
|
||||
{"teamId": ids.teamA}, {"teamId": ids.teamA}}}, "出现了两次"},
|
||||
{"权重为负", map[string]any{"teamShares": []map[string]any{
|
||||
{"teamId": ids.teamA, "weight": -1}}}, "不能为负数"},
|
||||
{"单位不存在", map[string]any{"teamShares": []map[string]any{
|
||||
{"teamId": ids.teamA}, {"teamId": 999999}}}, "不存在或已删除"},
|
||||
}
|
||||
for _, tc := range cases {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
status, resp := env.do(client, http.MethodPut, path, tc.body, true)
|
||||
if status != http.StatusBadRequest {
|
||||
t.Fatalf("应 400,得到 %d %+v", status, resp)
|
||||
}
|
||||
if resp.Error == nil || !strings.Contains(resp.Error.Message, tc.want) {
|
||||
t.Fatalf("报错应含 %q,得到 %+v", tc.want, resp.Error)
|
||||
}
|
||||
// 拦下就不能落库:份额表必须一个字节都没动。
|
||||
if got := tableDump(t, env, `SELECT team_id, points_share FROM entry_team_shares ORDER BY team_id`); got != baseline {
|
||||
t.Fatalf("被拒的请求改动了份额表:\n之前 %s之后 %s", baseline, got)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
// 报名表里非法写法的联队:拦下这一行并给出照得着改的报错,其余行照常导入。
|
||||
func TestImportJointTeamRejectsBadForms(t *testing.T) {
|
||||
cases := []struct {
|
||||
name string
|
||||
teamCode string
|
||||
want string
|
||||
}{
|
||||
{"成员单位不存在", "A+ZZ", "单位 ZZ 不存在(来自联队编码 A+ZZ)"},
|
||||
{"加号后面缺一段", "A+", "里有一段是空的"},
|
||||
{"加号前面缺一段", "+B", "里有一段是空的"},
|
||||
{"同一个单位写两遍", "A+A", "同一个单位出现了两次"},
|
||||
{"成员太多", "A+B+C+D+E+F", "一个联队最多 5 个单位"},
|
||||
}
|
||||
for _, tc := range cases {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
env, ids, client := recorderWithSeed(t)
|
||||
eventID, _ := seedMatchEvent(t, env, ids)
|
||||
|
||||
// 前面一行是正常的单单位报名:它必须照常导入(坏行不能拖垮整张表)。
|
||||
status, resp := importCSV(t, env, client,
|
||||
jointImportRow("BALL", "男子", "A"),
|
||||
jointImportRow("BALL", "男子", tc.teamCode),
|
||||
)
|
||||
if status != http.StatusOK || !resp.OK {
|
||||
t.Fatalf("导入端点应 200(逐行报错),得到 %d %+v", status, resp.Error)
|
||||
}
|
||||
result := decodeData[map[string]any](t, resp)
|
||||
if result["created"].(float64) != 1 || result["skipped"].(float64) != 1 {
|
||||
t.Fatalf("应 1 条成功 1 条跳过,得到 %+v", result)
|
||||
}
|
||||
errs, _ := result["errors"].([]any)
|
||||
if len(errs) != 1 || !strings.Contains(fmt.Sprint(errs[0]), tc.want) {
|
||||
t.Fatalf("第 2 行的报错应含 %q,得到 %+v", tc.want, errs)
|
||||
}
|
||||
if n := countRows(t, env, `SELECT COUNT(*) FROM entries WHERE event_id = ?`, eventID); n != 1 {
|
||||
t.Fatalf("坏行不该落库,报名数 = %d(明细:\n%s)", n, sharesDump(t, env, eventID))
|
||||
}
|
||||
// 成功那行必须是「主单位独占」一条:坏行的解析结果不能污染它。
|
||||
entryID := firstEntryID(t, env, eventID)
|
||||
want := shareRow(entryID, 0, ids.teamA, ids.teamA, 1, 1, 0)
|
||||
if got := sharesDump(t, env, eventID); got != want {
|
||||
t.Fatalf("正常行应只挂主单位一条份额:\n得到 %s期望 %s", got, want)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
// 全角加号与两侧空格照样认(现场用中文输入法填表,打出来的常是全角)。
|
||||
func TestImportJointTeamAcceptsFullWidthPlus(t *testing.T) {
|
||||
env, ids, client := recorderWithSeed(t)
|
||||
eventID, _ := seedMatchEvent(t, env, ids)
|
||||
if status, resp := importCSV(t, env, client, jointImportRow("BALL", "男子", "A + B")); status != http.StatusOK {
|
||||
t.Fatalf("导入应 200,得到 %d %+v", status, resp.Error)
|
||||
}
|
||||
entryID := firstEntryID(t, env, eventID)
|
||||
want := shareRow(entryID, 0, ids.teamA, ids.teamA, 1, 1, 0) +
|
||||
shareRow(entryID, 0, ids.teamA, ids.teamB, 1, 1, 1)
|
||||
if got := sharesDump(t, env, eventID); got != want {
|
||||
t.Fatalf("全角加号应解析成同一个联队:\n得到 %s期望 %s", got, want)
|
||||
}
|
||||
}
|
||||
|
||||
// 联队改回单单位(或换成员单位)时份额必须跟着变:只增不改会把旧配置一直用下去。
|
||||
func TestImportJointTeamResetsSharesOnReimport(t *testing.T) {
|
||||
env, ids, client := recorderWithSeed(t)
|
||||
eventID, _ := seedMatchEvent(t, env, ids)
|
||||
if status, resp := importCSV(t, env, client, jointImportRow("BALL", "男子", "A+B")); status != http.StatusOK {
|
||||
t.Fatalf("导入联队报名应 200,得到 %d %+v", status, resp.Error)
|
||||
}
|
||||
status, resp := importCSV(t, env, client, jointImportRow("BALL", "男子", "A"))
|
||||
if status != http.StatusOK || !resp.OK {
|
||||
t.Fatalf("重传单单位应 200,得到 %d %+v", status, resp.Error)
|
||||
}
|
||||
if result := decodeData[map[string]any](t, resp); result["updated"].(float64) != 1 {
|
||||
t.Fatalf("应更新同一行,得到 %+v", result)
|
||||
}
|
||||
entryID := firstEntryID(t, env, eventID)
|
||||
want := shareRow(entryID, 0, ids.teamA, ids.teamA, 1, 1, 0)
|
||||
if got := sharesDump(t, env, eventID); got != want {
|
||||
t.Fatalf("改回单单位后份额应只剩主单位一条:\n得到 %s期望 %s", got, want)
|
||||
}
|
||||
}
|
||||
|
||||
// 单个单位的报名照旧:库里写一条「主单位独占 100%」,读接口也下发一条,前端不必分支。
|
||||
func TestSingleUnitEntryKeepsWholeShare(t *testing.T) {
|
||||
env, ids, client := recorderWithSeed(t)
|
||||
eventID, categoryID := seedMatchEvent(t, env, ids)
|
||||
if status, resp := importCSV(t, env, client, jointImportRow("BALL", "男子", "A")); status != http.StatusOK {
|
||||
t.Fatalf("导入应 200,得到 %d %+v", status, resp.Error)
|
||||
}
|
||||
entryID := firstEntryID(t, env, eventID)
|
||||
want := shareRow(entryID, 0, ids.teamA, ids.teamA, 1, 1, 0)
|
||||
if got := sharesDump(t, env, eventID); got != want {
|
||||
t.Fatalf("单单位报名应写一条独占份额:\n得到 %s期望 %s", got, want)
|
||||
}
|
||||
|
||||
board := getEntryBoard(t, env, client, eventID)
|
||||
if len(board.Entries) != 1 {
|
||||
t.Fatalf("应有一条报名,得到 %+v", board.Entries)
|
||||
}
|
||||
shares, _ := board.Entries[0]["teamShares"].([]any)
|
||||
if len(shares) != 1 {
|
||||
t.Fatalf("读接口应下发一条份额(普通报名也一样),得到 %+v", board.Entries[0]["teamShares"])
|
||||
}
|
||||
share, _ := shares[0].(map[string]any)
|
||||
if share["teamId"] != float64(ids.teamA) || share["weight"] != float64(1) || share["teamCode"] != "A" {
|
||||
t.Fatalf("份额读数应为 {teamId:A, weight:1, teamCode:A},得到 %+v", share)
|
||||
}
|
||||
|
||||
// 独占口径下名次与积分照旧:第 1 名 15 分全给 A,B 一分没有。
|
||||
if status, resp := putTeamRanks(t, env, client, eventID, categoryID, []map[string]any{
|
||||
{"teamId": ids.teamA, "rank": 1},
|
||||
}); status != http.StatusOK {
|
||||
t.Fatalf("录团体名次应 200,得到 %d %+v", status, resp.Error)
|
||||
}
|
||||
assertStanding(t, env, client, ids.teamA, 15, 1, 0, 0)
|
||||
assertStanding(t, env, client, ids.teamB, 0, 0, 0, 0)
|
||||
}
|
||||
|
||||
// 人员匹配可能把报名改挂到库里那条档案的单位(keep-existing 的既有口径「报名跟随库里已有的单位」):
|
||||
// 份额必须跟着**最终主单位**走。跟不上的话就会出现「报名挂在 A 名下、分却记给了表格里写的 B」——
|
||||
// 现场看不出来,但榜单直接是错的。
|
||||
func TestImportSharesFollowMatchedUnit(t *testing.T) {
|
||||
env, ids, client := recorderWithSeed(t)
|
||||
env.exec(t, `UPDATE athletes SET id_card = '110101199001011234', bib = 'A100' WHERE id = ?`, ids.athleteA)
|
||||
|
||||
// 表里写 B,库里这个人的单位是 A,用户选 keep-existing → 报名仍挂在 A。
|
||||
body := importHeader + "\nM100,男子,B,张伟,110101199001011234,男,,A100,,registered,\n"
|
||||
decisions := `[{"idCard":"110101199001011234","action":"keep-existing"}]`
|
||||
status, resp := env.postImport(t, client, "/api/entries/import/resolve", body, decisions)
|
||||
if status != http.StatusOK || !resp.OK {
|
||||
t.Fatalf("决策导入应 200,得到 %d %+v", status, resp.Error)
|
||||
}
|
||||
|
||||
want := shareRow(ids.entryA, ids.athleteA, ids.teamA, ids.teamA, 1, 1, 0) +
|
||||
shareAbsentRow(ids.entryB, ids.athB, ids.teamB)
|
||||
if got := sharesDump(t, env, ids.event); got != want {
|
||||
t.Fatalf("份额应跟随最终主单位 A:\n得到 %s期望 %s", got, want)
|
||||
}
|
||||
|
||||
// 榜单上分也只能记给 A:报名挂在 A 名下,B 一分没有。
|
||||
publishResults(t, env, client, ids.event, "shares-follow-matched-unit",
|
||||
map[string]any{"entryId": ids.entryA, "resultValue": 11.2, "resultText": "11.2", "unit": "秒", "status": "ok"})
|
||||
assertStanding(t, env, client, ids.teamA, 10, 1, 0, 0)
|
||||
assertStanding(t, env, client, ids.teamB, 0, 0, 0, 0)
|
||||
}
|
||||
@@ -1291,19 +1291,16 @@ func (s *server) importEntriesWith(ctx context.Context, sheets []importSheet, de
|
||||
continue
|
||||
}
|
||||
}
|
||||
teamID, err := s.lookupID(ctx, `SELECT id FROM teams WHERE code = ?`, teamCode)
|
||||
// team_code 写 `A+B` 就是联队(devdocs/19):解析出多个成员单位,第一个是主单位,
|
||||
// 分与奖牌按份额下发给各单位。成员单位的存在性、复活与报错都在里面,
|
||||
// 报错文案与单单位口径逐字一致(现场几百份老表的提示格式不该变样)。
|
||||
teamIDs, teamShares, err := s.lookupImportTeams(ctx, teamCode)
|
||||
if err != nil {
|
||||
result.Skipped++
|
||||
result.Errors = append(result.Errors, prefix+s.interceptRow(line, "单位 %s 不存在", teamCode))
|
||||
continue
|
||||
}
|
||||
// 编码查单位时不排除已隐藏的(编码有唯一索引,排除会撞索引或重复建档),
|
||||
// 命中就复活他:这一行马上要给他建报名,人却看不见就说不通了。
|
||||
if err := s.reviveTeam(ctx, teamID); err != nil {
|
||||
result.Skipped++
|
||||
result.Errors = append(result.Errors, prefix+s.interceptRow(line, "%s", err.Error()))
|
||||
continue
|
||||
}
|
||||
teamID := teamIDs[0]
|
||||
if table.scope == nil {
|
||||
if categoryName != "" {
|
||||
categoryID, err = s.lookupID(ctx, `SELECT id FROM event_categories WHERE event_id = ? AND name = ?`, eventID, categoryName)
|
||||
@@ -1427,10 +1424,19 @@ func (s *server) importEntriesWith(ctx context.Context, sheets []importSheet, de
|
||||
teamID = matched.TeamID
|
||||
}
|
||||
|
||||
// 份额必须跟着**最终**的主单位走:上面的人员匹配可能把报名改挂到库里那条档案的单位
|
||||
// (keep-existing 的既有口径「报名跟随库里已有的单位」)。主单位掉到表格写的成员之外时
|
||||
// 整组退回独占,与升级前一致——报名挂在哪个单位,分就记给哪个单位;
|
||||
// 否则会出现「报名挂在 A 名下、分却记给了表格里写的 B」这种看不见的错。
|
||||
if !sharesContainTeam(teamShares, teamID) {
|
||||
teamShares = nil
|
||||
}
|
||||
|
||||
outcome, err := s.upsertImportedEntry(ctx, entryDTO{
|
||||
EventID: eventID,
|
||||
CategoryID: categoryID,
|
||||
TeamID: teamID,
|
||||
TeamShares: teamShares,
|
||||
AthleteID: athleteID,
|
||||
MemberNames: splitNames(cell("member_names")),
|
||||
Bib: nilIfEmpty(bib),
|
||||
|
||||
@@ -0,0 +1,101 @@
|
||||
package httpapi_test
|
||||
|
||||
import (
|
||||
"net/http"
|
||||
"strings"
|
||||
"testing"
|
||||
)
|
||||
|
||||
// 报名模板要让填表人知道联队怎么写(devdocs/19):单位编码写 `A+B`,加号左边那个是主单位,
|
||||
// 积分平均分、奖牌两边各记一枚。
|
||||
//
|
||||
// 说明只能挂在「不会变成数据」的载体上:表头行是导入器认模板的锚点(必须留在第 1 行、
|
||||
// 12 列一成不变),工作表名是「小项@组别」的范围锚点(也不能多出说明表),
|
||||
// 所以这里用**单元格批注**(表头「单位编码」那一格)+ **该列的输入提示**(选中即弹出)。
|
||||
func TestEntriesTemplateExplainsJointTeamCode(t *testing.T) {
|
||||
env, _, client := recorderWithSeed(t)
|
||||
|
||||
for _, lang := range []string{"zh", "en"} {
|
||||
f, _ := env.fetchTemplate(t, client, lang)
|
||||
sheets := f.GetSheetList()
|
||||
if len(sheets) == 0 {
|
||||
t.Fatalf("lang=%s 模板没有工作表", lang)
|
||||
}
|
||||
for _, sheet := range sheets {
|
||||
comments, err := f.GetComments(sheet)
|
||||
if err != nil {
|
||||
t.Fatalf("[%s] 读工作表 %s 的批注: %v", lang, sheet, err)
|
||||
}
|
||||
if len(comments) != 1 {
|
||||
t.Fatalf("[%s] 工作表 %s 应有且仅有 1 条批注(挂在单位编码表头),得到 %d 条", lang, sheet, len(comments))
|
||||
}
|
||||
comment := comments[0]
|
||||
if comment.Cell != "C1" {
|
||||
t.Errorf("[%s] 批注应挂在单位编码表头 C1,得到 %s", lang, comment.Cell)
|
||||
}
|
||||
if !strings.Contains(comment.Text, "A+B") {
|
||||
t.Errorf("[%s] 批注没写清联队怎么写:%q", lang, comment.Text)
|
||||
}
|
||||
// 批注作者写系统名(与导出件的文档属性同一套),不是构建期注入的内部署名。
|
||||
if comment.Author != "赛事积分榜系统" {
|
||||
t.Errorf("[%s] 批注作者 = %q,期望系统名", lang, comment.Author)
|
||||
}
|
||||
|
||||
validations, err := f.GetDataValidations(sheet)
|
||||
if err != nil {
|
||||
t.Fatalf("[%s] 读工作表 %s 的输入提示: %v", lang, sheet, err)
|
||||
}
|
||||
prompt := ""
|
||||
for _, dv := range validations {
|
||||
if dv.Sqref != "" && strings.HasPrefix(dv.Sqref, "C2") && dv.Prompt != nil {
|
||||
prompt = *dv.Prompt
|
||||
}
|
||||
}
|
||||
if !strings.Contains(prompt, "A+B") {
|
||||
t.Errorf("[%s] 单位编码列的输入提示应写明联队写法,得到 %q", lang, prompt)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// 模板上的中文说明必须与导入的实际行为一致:照说明填 `A+B`,导进来就是一条报名挂两个单位、均分。
|
||||
func TestEntriesTemplateJointTeamRowImports(t *testing.T) {
|
||||
env, ids, client := recorderWithSeed(t)
|
||||
|
||||
f, _ := env.fetchTemplate(t, client, "")
|
||||
// 范围由表名承担,「项目编码 / 组别」两列留空;单位编码按模板说明写 A+B。
|
||||
appendRows(t, f, "100米跑@男子", [][]string{{
|
||||
"", "", "A+B", "联队小张", "110101199001011234", "男", "26", "301", "", "1", "registered", "",
|
||||
}})
|
||||
|
||||
status, resp := env.uploadEntries(t, client, "报名模板.xlsx", workbookBytes(t, f))
|
||||
if status != http.StatusOK || !resp.OK {
|
||||
t.Fatalf("照模板说明填的联队行应导入成功,得到 %d %+v", status, resp.Error)
|
||||
}
|
||||
if result := decodeData[entryImportResultBody](t, resp); len(result.Errors) != 0 {
|
||||
t.Fatalf("不该有报错行:%v", result.Errors)
|
||||
}
|
||||
|
||||
// 落库事实:新报名一条、两个单位各占一份(权重 1 = 均分),主单位是加号左边的 A。
|
||||
var entryID int64
|
||||
if err := env.ev.QueryRow(
|
||||
`SELECT e.id FROM entries e JOIN athletes a ON a.id = e.athlete_id
|
||||
WHERE e.event_id = ? AND a.name = '联队小张'`, ids.event).Scan(&entryID); err != nil {
|
||||
t.Fatalf("查新报名: %v", err)
|
||||
}
|
||||
var primary, shares int
|
||||
if err := env.ev.QueryRow(`SELECT team_id FROM entries WHERE id = ?`, entryID).Scan(&primary); err != nil {
|
||||
t.Fatalf("查主单位: %v", err)
|
||||
}
|
||||
if int64(primary) != ids.teamA {
|
||||
t.Errorf("主单位应是加号左边的 A(%d),得到 %d", ids.teamA, primary)
|
||||
}
|
||||
if err := env.ev.QueryRow(
|
||||
`SELECT COUNT(*) FROM entry_team_shares WHERE entry_id = ? AND points_share = 1 AND medal_share = 1`,
|
||||
entryID).Scan(&shares); err != nil {
|
||||
t.Fatalf("查份额: %v", err)
|
||||
}
|
||||
if shares != 2 {
|
||||
t.Errorf("联队报名的份额行 = %d,期望 2(两个单位各一份、均分、奖牌各整枚)", shares)
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,150 @@
|
||||
package httpapi_test
|
||||
|
||||
import (
|
||||
"crypto/sha256"
|
||||
"encoding/hex"
|
||||
"fmt"
|
||||
"net/http"
|
||||
"strings"
|
||||
"testing"
|
||||
)
|
||||
|
||||
// 本文件是联队改动(devdocs/19)的「老数据零变化」硬门槛在**接口层**的一半:
|
||||
// 四种形态(普通个人 / 纯团体 / 双计 / 团体报名项双通道)走真实的导入 · 发布 · 录名次接口,
|
||||
// 再把积分榜、个人榜、报名 / 成绩 / 流水 / 通道名次四张表的原始内容拼成一份签名。
|
||||
//
|
||||
// 签名取自**联队实现之前**的代码(git archive HEAD 的修前副本上跑出来的),实现之后必须一字不差。
|
||||
//
|
||||
// 为什么特意**不含** GET /api/events/{id}/entries:那条读接口这次有意新增了 teamShares 字段
|
||||
// (联队的成员单位与权重,前端据此渲染「A+B联队」),契约变了不该算回归;
|
||||
// 它由 TestSingleUnitEntryKeepsWholeShare 单独钉住(普通报名下发一条独占份额)。
|
||||
const legacyFormsGoldenAPI = "aa6cea376734cfc5f2334551dfa3095f31543babb10e00c2318b5146a8af42d2"
|
||||
|
||||
// TestLegacyFormsAPISnapshotUnchanged 对拍四种形态的榜单与落库事实。
|
||||
func TestLegacyFormsAPISnapshotUnchanged(t *testing.T) {
|
||||
env, ids, client := recorderWithSeed(t)
|
||||
dump := legacyFormsAPIDump(t, env, client, ids)
|
||||
|
||||
// 防空转:签名里必须真的能看到四种形态的痕迹。少了这几处,对拍就成了「两份空文本相等」。
|
||||
if n := strings.Count(dump, `"totalPoints"`); n < 3 {
|
||||
t.Fatalf("积分榜签名里只有 %d 行(三个单位都该在榜上):\n%s", n, dump)
|
||||
}
|
||||
if !strings.Contains(dump, "t:") || !strings.Contains(dump, "e:") {
|
||||
t.Fatalf("签名里应同时有「按单位录的名次」与「按报名项的名次」:\n%s", dump)
|
||||
}
|
||||
if !strings.Contains(dump, "points=") || !strings.Contains(dump, "subject_key") {
|
||||
t.Fatalf("签名里应带上流水与通道名次的落库事实:\n%s", dump)
|
||||
}
|
||||
|
||||
sum := sha256.Sum256([]byte(dump))
|
||||
got := hex.EncodeToString(sum[:])
|
||||
if got != legacyFormsGoldenAPI {
|
||||
t.Fatalf("无联队的老数据在榜单 / 流水 / 名次上变了:\n签名 = %s\n期望 = %s",
|
||||
got, legacyFormsGoldenAPI)
|
||||
}
|
||||
}
|
||||
|
||||
// legacyFormsAPIDump 造出四种形态并拼出签名文本。
|
||||
func legacyFormsAPIDump(t *testing.T, env *testEnv, client *http.Client, ids seedIDs) string {
|
||||
t.Helper()
|
||||
|
||||
// 第三个单位:颁奖牌榜上要有「没参加这个项目」的行,才能看出兜底行有没有变化。
|
||||
teamC := env.insert(t, `INSERT INTO teams (code, name, short_name, sort_order, active)
|
||||
VALUES ('C', '第三分公司', '三司', 2, 1)`)
|
||||
athC := env.insert(t, `INSERT INTO athletes (name, gender, team_id, active)
|
||||
VALUES ('王芳', '女', ?, 1)`, teamC)
|
||||
|
||||
// 形态 1 · 普通个人:seed 的 M100(individual + 个人成绩通道)。
|
||||
env.exec(t, `INSERT INTO entries (event_id, category_id, team_id, athlete_id, status)
|
||||
VALUES (?, ?, ?, ?, 'registered')`, ids.event, ids.category, teamC, athC)
|
||||
publishResults(t, env, client, ids.event, "legacy-individual",
|
||||
map[string]any{"entryId": ids.entryA, "resultValue": 11.2, "resultText": "11.2", "unit": "秒", "status": "ok"},
|
||||
map[string]any{"entryId": ids.entryB, "resultValue": 11.5, "resultText": "11.5", "unit": "秒", "status": "ok"},
|
||||
map[string]any{"entryId": envEntryID(t, env, ids.event, athC), "resultValue": 12.0, "resultText": "12.0", "unit": "秒", "status": "ok"},
|
||||
)
|
||||
|
||||
// 形态 2 · 纯团体:球类(match)+ 按单位录的团体名次。
|
||||
ballEvent, ballCategory := seedMatchEvent(t, env, ids)
|
||||
if status, resp := putTeamRanks(t, env, client, ballEvent, ballCategory, []map[string]any{
|
||||
{"teamId": ids.teamA, "rank": 1},
|
||||
{"teamId": ids.teamB, "rank": 2},
|
||||
{"teamId": teamC, "rank": 2},
|
||||
}); status != http.StatusOK {
|
||||
t.Fatalf("录团体名次应 200,得到 %d %+v", status, resp.Error)
|
||||
}
|
||||
|
||||
// 形态 3 · 双计:个人成绩通道(不计入单位总分)+ 团体聚合通道。
|
||||
mixEvent := env.insert(t, `INSERT INTO events (sport_id, code, name, event_type, result_mode, result_type,
|
||||
compare, scored, multiplier, status)
|
||||
VALUES (?, 'MIX2', '团体引体向上', 'individual_team', 'auto', 'count', 'desc', 1, 1, 'ongoing')`, ids.sport)
|
||||
mixCategory := env.insert(t, `INSERT INTO event_categories (event_id, name, multiplier, sort_order)
|
||||
VALUES (?, '男子', 1, 0)`, mixEvent)
|
||||
env.exec(t, `INSERT INTO event_score_channels (event_id, scope, basis, profile_id, sort_order, count_to_team)
|
||||
VALUES (?, 'athlete', 'result', ?, 0, 0)`, mixEvent, profileIDByCode(t, env, "individual_top6"))
|
||||
env.exec(t, `INSERT INTO event_score_channels (event_id, scope, basis, profile_id, sort_order)
|
||||
VALUES (?, 'team', 'aggregate', ?, 1)`, mixEvent, profileIDByCode(t, env, "team_top6"))
|
||||
mixRows := make([]map[string]any, 0, 3)
|
||||
for i, athleteID := range []int64{ids.athleteA, ids.athB, athC} {
|
||||
entryID := env.insert(t, `INSERT INTO entries (event_id, category_id, team_id, athlete_id, status)
|
||||
VALUES (?, ?, ?, ?, 'registered')`, mixEvent, mixCategory, []int64{ids.teamA, ids.teamB, teamC}[i], athleteID)
|
||||
mixRows = append(mixRows, map[string]any{
|
||||
"entryId": entryID, "resultValue": 10 + i, "resultText": fmt.Sprint(10 + i), "unit": "次", "status": "ok",
|
||||
})
|
||||
}
|
||||
publishResults(t, env, client, mixEvent, "legacy-individual-team", mixRows...)
|
||||
|
||||
// 形态 4 · 团体报名项双通道:团体报名项(athlete_id 为空)+ 个人成绩通道 + 团体手工通道。
|
||||
dualEvent := env.insert(t, `INSERT INTO events (sport_id, code, name, event_type, result_mode, result_type,
|
||||
compare, scored, multiplier, status)
|
||||
VALUES (?, 'DUAL', '混合配置试验', 'team', 'auto', 'count', 'desc', 1, 1, 'ongoing')`, ids.sport)
|
||||
dualCategory := env.insert(t, `INSERT INTO event_categories (event_id, name, multiplier, sort_order)
|
||||
VALUES (?, '男子', 1, 0)`, dualEvent)
|
||||
env.exec(t, `INSERT INTO event_score_channels (event_id, scope, basis, profile_id, sort_order)
|
||||
VALUES (?, 'athlete', 'result', ?, 0)`, dualEvent, profileIDByCode(t, env, "individual_top6"))
|
||||
env.exec(t, `INSERT INTO event_score_channels (event_id, scope, basis, profile_id, sort_order)
|
||||
VALUES (?, 'team', 'manual', ?, 1)`, dualEvent, profileIDByCode(t, env, "team_top6"))
|
||||
dualRows := make([]map[string]any, 0, 3)
|
||||
for i, teamID := range []int64{ids.teamA, ids.teamB, teamC} {
|
||||
entryID := env.insert(t, `INSERT INTO entries (event_id, category_id, team_id, athlete_id, status)
|
||||
VALUES (?, ?, ?, NULL, 'registered')`, dualEvent, dualCategory, teamID)
|
||||
dualRows = append(dualRows, map[string]any{
|
||||
"entryId": entryID, "resultValue": 90 - 10*i, "resultText": fmt.Sprint(90 - 10*i), "unit": "次", "status": "ok",
|
||||
})
|
||||
}
|
||||
publishResults(t, env, client, dualEvent, "legacy-dual", dualRows...)
|
||||
// 团体名次按单位录(覆盖值优先于报名项自己的名次):这一支产出的名次没有报名项,
|
||||
// subject_key 是「单位」,正是这次改动碰过的地方。
|
||||
if status, resp := putTeamRanks(t, env, client, dualEvent, dualCategory, []map[string]any{
|
||||
{"teamId": ids.teamA, "rank": 2},
|
||||
{"teamId": ids.teamB, "rank": 1},
|
||||
{"teamId": teamC, "rank": 3},
|
||||
}); status != http.StatusOK {
|
||||
t.Fatalf("录团体名次应 200,得到 %d %+v", status, resp.Error)
|
||||
}
|
||||
|
||||
return strings.Join([]string{
|
||||
rawData(t, env, client, "/api/standings"),
|
||||
rawData(t, env, client, "/api/standings/athletes"),
|
||||
tableDump(t, env, `SELECT id, event_id, category_id, team_id, COALESCE(athlete_id, 0) AS athlete_id, status
|
||||
FROM entries ORDER BY id`),
|
||||
tableDump(t, env, `SELECT id, event_id, entry_id, COALESCE(rank, 0) AS rank, COALESCE(result_value, 0) AS value,
|
||||
status, state FROM results ORDER BY id`),
|
||||
tableDump(t, env, `SELECT id, team_id, COALESCE(athlete_id, 0) AS athlete_id, COALESCE(event_id, 0) AS event_id,
|
||||
COALESCE(entry_id, 0) AS entry_id, source_type, source_id, points, count_to_team, voided
|
||||
FROM score_ledger ORDER BY id`),
|
||||
tableDump(t, env, `SELECT id, event_id, category_id, channel_id, basis, scope, subject_key,
|
||||
COALESCE(entry_id, 0) AS entry_id, COALESCE(team_id, 0) AS team_id, rank, points
|
||||
FROM channel_ranks ORDER BY id`),
|
||||
}, "\n---\n") + "\n"
|
||||
}
|
||||
|
||||
// envEntryID 取某小项里某运动员的报名项 id。
|
||||
func envEntryID(t *testing.T, env *testEnv, eventID, athleteID int64) int64 {
|
||||
t.Helper()
|
||||
var id int64
|
||||
if err := env.ev.QueryRow(
|
||||
`SELECT id FROM entries WHERE event_id = ? AND athlete_id = ?`, eventID, athleteID).Scan(&id); err != nil {
|
||||
t.Fatalf("读报名项: %v", err)
|
||||
}
|
||||
return id
|
||||
}
|
||||
@@ -45,6 +45,14 @@ type entryHeatPayload struct {
|
||||
RequestID string `json:"requestId"`
|
||||
}
|
||||
|
||||
// entryTeamSharesPayload 是 PUT /api/entries/{id}/team-shares 的请求体:整组替换一条报名的份额。
|
||||
// 不传重量字段(weight 缺省 1)就是均分;medal 缺省 true = 这枚奖牌整枚记给该单位。
|
||||
// 必须包含主单位(entries.team_id),且每个单位只能出现一次——校验见 validateEntryShares。
|
||||
type entryTeamSharesPayload struct {
|
||||
TeamShares []entryTeamShareDTO `json:"teamShares"`
|
||||
RequestID string `json:"requestId"`
|
||||
}
|
||||
|
||||
// entryBatchPayload 是报名项批量操作的请求体:
|
||||
// action 决定语义(scratch 退赛可恢复 / restore 恢复 / remove 物理移出报名),
|
||||
// ids 是勾选的报名项(重复会自动去重),reason 可选、只进审计便于事后对账。
|
||||
|
||||
@@ -832,7 +832,18 @@ func (s *server) listEntries(ctx context.Context, eventID int64) ([]entryDTO, er
|
||||
}
|
||||
out = append(out, e)
|
||||
}
|
||||
return out, rows.Err()
|
||||
if err := rows.Err(); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
// 份额单独查一次再挂上:一个报名可能有多条(联队),join 进上面那条 SQL 会把报名行乘开。
|
||||
shares, err := s.loadEntrySharesDTOs(ctx, s.ev, eventID)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
for i := range out {
|
||||
out[i].TeamShares = entrySharesOf(shares[out[i].ID], out[i].TeamID, out[i].TeamCode, out[i].TeamName)
|
||||
}
|
||||
return out, nil
|
||||
}
|
||||
|
||||
// listEntriesWithResults 返回报名项及其成绩(无成绩时 result=null)。
|
||||
|
||||
@@ -674,11 +674,19 @@ func (s *server) upsertImportedEntry(ctx context.Context, in entryDTO) (entryImp
|
||||
if err != nil {
|
||||
return entryImportOutcome{}, err
|
||||
}
|
||||
if _, err := s.ev.ExecContext(ctx,
|
||||
res, err := s.ev.ExecContext(ctx,
|
||||
`INSERT INTO entries (event_id, category_id, team_id, athlete_id, member_names, bib, seed, heat, status)
|
||||
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)`,
|
||||
in.EventID, in.CategoryID, in.TeamID, nullI64(in.AthleteID), marshalNames(in.MemberNames),
|
||||
nullStr(in.Bib), nullStr(in.Seed), nullI64(in.Heat), status); err != nil {
|
||||
nullStr(in.Bib), nullStr(in.Seed), nullI64(in.Heat), status)
|
||||
if err != nil {
|
||||
return entryImportOutcome{}, err
|
||||
}
|
||||
newID, err := res.LastInsertId()
|
||||
if err != nil {
|
||||
return entryImportOutcome{}, internal(err)
|
||||
}
|
||||
if err := replaceEntryShares(ctx, s.ev, newID, in.TeamID, in.TeamShares); err != nil {
|
||||
return entryImportOutcome{}, err
|
||||
}
|
||||
outcome := entryImportOutcome{Created: true, EventID: in.EventID, CategoryID: in.CategoryID}
|
||||
@@ -705,6 +713,11 @@ func (s *server) upsertImportedEntry(ctx context.Context, in entryDTO) (entryImp
|
||||
status, existing); err != nil {
|
||||
return entryImportOutcome{}, err
|
||||
}
|
||||
// 份额整组重写:同一行重传要幂等,改了写法(联队改回单单位、换成员)也要跟着变,
|
||||
// 只增不改会把上一次的配置一直用下去(见 replaceEntryShares)。
|
||||
if err := replaceEntryShares(ctx, s.ev, existing, in.TeamID, in.TeamShares); err != nil {
|
||||
return entryImportOutcome{}, err
|
||||
}
|
||||
return entryImportOutcome{
|
||||
EventID: in.EventID,
|
||||
CategoryID: in.CategoryID,
|
||||
|
||||
@@ -619,17 +619,26 @@ func (s *server) buildRanked(ctx context.Context, q queryer) ([]domain.RankedRes
|
||||
v := value.Float64
|
||||
rr.ResultValue = &v
|
||||
}
|
||||
// 归属份额沿用「主单位独占 100%」:team_id 为空(理论上不会)时不造份额,
|
||||
// 免得给 0 号单位凭空记牌,与 domain 的 wholeShare 一致。
|
||||
if rr.TeamID != 0 {
|
||||
rr.Shares = []domain.TeamShare{{TeamID: rr.TeamID, Weight: 1}}
|
||||
}
|
||||
rr.AwardMedals = awardMedals != 0
|
||||
rr.CountToMedals = countToMedals != 0
|
||||
rr.CountToTeamMedals = countToTeamMedals != 0
|
||||
out = append(out, rr)
|
||||
}
|
||||
return out, rows.Err()
|
||||
if err := rows.Err(); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
// 归属份额按报名项的配置补:channel_ranks 只存名次与主体(entry_id 有外键、可回查),
|
||||
// 份额是报名项上的配置,引擎与榜单两边都必须从同一处读——
|
||||
// 没有报名项的名次(聚合 / 团体手工)与没配份额的老数据都退回「主单位独占 100%」,
|
||||
// 与 domain.ResolveShares 同一口径(老数据因此一分一牌都不变)。
|
||||
shares, err := loadEntryTeamSharesQ(ctx, q, 0)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
for i := range out {
|
||||
out[i].Shares = domain.ResolveShares(shares[out[i].EntryID], out[i].TeamID)
|
||||
}
|
||||
return out, nil
|
||||
}
|
||||
|
||||
// breakdownRankExpr 取一条单位流水的名次(devdocs 17 §11.3):优先按流水对应的通道与主体
|
||||
|
||||
@@ -236,7 +236,18 @@ func loadEntriesQ(ctx context.Context, q queryer, eventID, categoryID int64) ([]
|
||||
e.MemberNames = parseNames(memberNames)
|
||||
out = append(out, e)
|
||||
}
|
||||
return out, rows.Err()
|
||||
if err := rows.Err(); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
// 联队份额随报名一起进引擎:引擎不看库,取分只认 Entry.TeamShares。
|
||||
shares, err := loadEntryTeamSharesQ(ctx, q, eventID)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
for i := range out {
|
||||
out[i].TeamShares = shares[out[i].ID]
|
||||
}
|
||||
return out, nil
|
||||
}
|
||||
|
||||
func loadResultsQ(ctx context.Context, q queryer, eventID, categoryID int64) ([]domain.Result, error) {
|
||||
@@ -503,7 +514,8 @@ func hasSubjectChannel(ctx context.Context, tx *sql.Tx, eventID int64) (bool, er
|
||||
// 结算范围与流水一致:categoryID > 0 只重建该组别,否则重建整个小项。
|
||||
// SubjectKey 是 (通道, 组别, 主体) 的唯一键,聚合与团体手工名次没有报名项,靠它落库。
|
||||
// AwardMedals / CountToMedals / CountToTeamMedals 是读取侧 join events / event_score_channels
|
||||
// 得到的,不落这张表;shares 不进表(当前只有「主单位独占 100%」一种口径,读取侧按 team_id 重建)。
|
||||
// 得到的,不落这张表;shares 同样不进表——读取侧按 entry_id 回查报名份额(entry_team_shares),
|
||||
// 回查不到(没有报名项的名次、没配份额的老数据)与引擎一样退回「主单位独占 100%」。
|
||||
func writeChannelRanksTx(ctx context.Context, tx *sql.Tx, score domain.EventScore, eventID, categoryID int64) error {
|
||||
if categoryID > 0 {
|
||||
if _, err := tx.ExecContext(ctx,
|
||||
|
||||
@@ -276,6 +276,9 @@ func (s *server) routes(mux *http.ServeMux) {
|
||||
// 报名项批量操作:退赛(scratched,可恢复)/ 恢复 / 移出报名(物理删除,不可恢复)。
|
||||
// 权限与发布同档(recorder),不新增角色;跨小项混选允许,服务端按 (小项, 组别) 分组重算。
|
||||
mux.HandleFunc("POST /api/entries/batch", s.write(auth.RoleRecorder, s.batchEntriesHandler))
|
||||
// 联队份额(devdocs/19):改一条报名的成员单位与权重,改完当场重算并推榜。
|
||||
// 与其它报名写入同档权限(recorder):它改的是报名,权限不该比报名导入更宽。
|
||||
mux.HandleFunc("PUT /api/entries/{id}/team-shares", s.write(auth.RoleRecorder, s.updateEntryTeamSharesHandler))
|
||||
|
||||
// 成绩
|
||||
mux.HandleFunc("GET /api/results", s.public(s.listResultsHandler))
|
||||
|
||||
Reference in new issue
Block a user