fix: 修掉十路审查发现的 9 个 P0 与一批 P1（数据正确性 / 越权 / 现场可用性）
P0（9 条全修）： - 多通道项目奖牌重复计数：domain 层按 (EventID,CategoryID,EntryID/Subject) 去重， 通道优先级 athlete→team→id - 「只排名不计分」项目（scored:false）不再进奖牌榜，REST/WS/导出口径统一 - aggregate 流水 entry_id 恒 NULL 导致重算后分数翻倍：作废范围改按 event+category 定位 - 已发布成绩仍可被「存草稿」覆盖并清空 rank：服务端 409 STATE_INVALID + 前端禁编辑 - voidResult / 规则导入重算后名次不回写：接住 Ranked 调 applyComputedRanks - 赛事包覆盖导入可能「旧项目已删、新项目没成」：先改名成功再清理，失败回滚 - 导入赛事包可覆盖正在运行的赛事目录：name==当前项目直接 400 - Console spawn 失败后守护器永久卡死：清 child/pid + 调度重启 + stop 超时兜底 - /ws 快照向非 admin 下发 admin-only 配置：按角色裁剪 settings P1（计分口径 / 契约 / 现场）： - standings.tieBreak 三处接线；profiles[].recordBonusMode 生效；破纪录校验 RecordEligible 与 entry 归属；破纪录登记校验已发布成绩 - export.loadRanked 与主路径对齐；ListBackups reason 解析；CLI backup 前缀修正 （原来只增不减会撑爆磁盘）；单位积分明细/导出统一权重折算；停用单位展示 - 规则导入原子化（重算并入同一事务）+ 返回 compatible/affectedEventCount/ recalculatedLedgerRows；登录审计 user_id 修正 - WS 策略性断开用 Close(code,reason)；HelloMessage 补 page/instanceId； 实例注册表清理；settings/单位/项目写操作补 change_log 触发大屏刷新 - 大屏：全量快照不再被版本守卫丢弃；个人积分榜刷新；公告返回页/轮播；行数截断； REST 竞态；1008 停止重连；握手超时；时区补 Z；401 仅 AUTH_REQUIRED 才登出 - 管理端：published 行禁编辑；saveDraft 补 unit（1:06.33 显示）；前端预览改用服务端 points；空成绩行不再恒「已修改」；修订详情按 id 拉取；切项目请求序号与 dirty 保护； 发布后刷新项目状态；NAV/路由按角色过滤；recorder 不再打 admin-only 接口 - Console：大屏窗口销毁后重建；大屏 URL 复用 host 归一化；backup.bat 改纯 ASCII （已在 Meowhome 实跑验证） 自检：服务端 gofmt/build/vet 通过、12 包测试全绿；前端 vue-tsc + build 通过、 node --test 24/24；console check-syntax 12 文件通过。
This commit is contained in:
AskaEth committed
1 parent
96cf181ae3
commit
13f1f03cd0
124 files changed
+5658
-1820
No files matched your search
@@ -2,8 +2,12 @@ package store
|
||||
|
||||
import (
|
||||
"database/sql"
|
||||
"io/fs"
|
||||
"path/filepath"
|
||||
"sort"
|
||||
"testing"
|
||||
|
||||
"git.yeij.top/AskaEth/Scoreboard/server/migrations"
|
||||
)
|
||||
|
||||
// openEventDB 打开一个临时赛事库；DSN 与 store.Open 保持一致，便于验证外键约束。
|
||||
@@ -127,6 +131,159 @@ func TestEventSchemaAcceptsCoreFlow(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
// 0012 迁移：score_ledger 补 (entry_id, voided) 索引，events 子表外键改为可级联/置空，
|
||||
// 删除没有任何报名的小项不再被历史流水与纪录挡住。
|
||||
func TestMigrateEventDeleteWithHistory(t *testing.T) {
|
||||
db := openEventDB(t)
|
||||
if err := MigrateEvent(db); err != nil {
|
||||
t.Fatalf("迁移: %v", err)
|
||||
}
|
||||
|
||||
assertIndex(t, db, "score_ledger", "idx_score_ledger_entry_voided")
|
||||
|
||||
mustExec(t, db, `INSERT INTO teams(code, name) VALUES ('T1', '第一分公司')`)
|
||||
mustExec(t, db, `INSERT INTO sports(code, name) VALUES ('SP1', '田径')`)
|
||||
mustExec(t, db, `INSERT INTO events(sport_id, code, name) VALUES (1, 'E1', '100米跑')`)
|
||||
mustExec(t, db, `INSERT INTO score_ledger(team_id, event_id, source_type, source_id, points)
|
||||
VALUES (1, 1, 'adjustment', 1, 5)`)
|
||||
mustExec(t, db, `INSERT INTO point_adjustments(team_id, delta, category, reason, event_id)
|
||||
VALUES (1, 5, 'bonus', '测试', 1)`)
|
||||
mustExec(t, db, `INSERT INTO records(event_id, level) VALUES (1, 'meet')`)
|
||||
|
||||
// 与 repo_events.go 的 deleteEvent 同序：先清通道/组别，再删小项。
|
||||
mustExec(t, db, `DELETE FROM event_score_channels WHERE event_id = 1`)
|
||||
mustExec(t, db, `DELETE FROM event_categories WHERE event_id = 1`)
|
||||
mustExec(t, db, `DELETE FROM events WHERE id = 1`)
|
||||
|
||||
// 积分流水与人工调整保留，只把 event_id 置空；纪录随小项删除。
|
||||
if got := countRows(t, db, "score_ledger"); got != 1 {
|
||||
t.Errorf("score_ledger 行数 = %d，期望 1", got)
|
||||
}
|
||||
if got := queryInt(t, db, `SELECT count(*) FROM score_ledger WHERE event_id IS NOT NULL`); got != 0 {
|
||||
t.Errorf("score_ledger.event_id 应置空，实际仍有 %d 行", got)
|
||||
}
|
||||
if got := queryInt(t, db, `SELECT count(*) FROM point_adjustments WHERE event_id IS NOT NULL`); got != 0 {
|
||||
t.Errorf("point_adjustments.event_id 应置空，实际仍有 %d 行", got)
|
||||
}
|
||||
if got := countRows(t, db, "records"); got != 0 {
|
||||
t.Errorf("records 应随小项级联删除，实际 %d 行", got)
|
||||
}
|
||||
|
||||
rows, err := db.Query(`PRAGMA foreign_key_check`)
|
||||
if err != nil {
|
||||
t.Fatalf("外键检查: %v", err)
|
||||
}
|
||||
defer func() { _ = rows.Close() }()
|
||||
if rows.Next() {
|
||||
t.Error("重建后存在外键悬挂")
|
||||
}
|
||||
if _, err := db.Exec(`INSERT INTO score_ledger(team_id, source_type, source_id, points)
|
||||
VALUES (999, 'adjustment', 1, 1)`); err == nil {
|
||||
t.Error("重建后 score_ledger.team_id 外键应仍然生效")
|
||||
}
|
||||
}
|
||||
|
||||
// 老库升级到 0012 时数据必须原样保留：重建表是「建新表 → 拷数据 → 换名」，不能吞行。
|
||||
func TestMigration0012PreservesExistingRows(t *testing.T) {
|
||||
db := openEventDB(t)
|
||||
fsys, err := fs.Sub(migrations.EventFS, "event")
|
||||
if err != nil {
|
||||
t.Fatalf("定位迁移目录: %v", err)
|
||||
}
|
||||
names, err := fs.Glob(fsys, "*.sql")
|
||||
if err != nil {
|
||||
t.Fatalf("列出迁移: %v", err)
|
||||
}
|
||||
sort.Strings(names)
|
||||
for _, name := range names {
|
||||
if name >= "0012" {
|
||||
continue
|
||||
}
|
||||
body, err := fs.ReadFile(fsys, name)
|
||||
if err != nil {
|
||||
t.Fatalf("读取迁移 %s: %v", name, err)
|
||||
}
|
||||
if _, err := db.Exec(string(body)); err != nil {
|
||||
t.Fatalf("应用迁移 %s: %v", name, err)
|
||||
}
|
||||
}
|
||||
|
||||
stmts := []string{
|
||||
`INSERT INTO teams(code, name) VALUES ('T1', '第一分公司')`,
|
||||
`INSERT INTO sports(code, name) VALUES ('SP1', '田径')`,
|
||||
`INSERT INTO events(sport_id, code, name) VALUES (1, 'E1', '100米跑')`,
|
||||
`INSERT INTO event_categories(event_id, name) VALUES (1, '男子')`,
|
||||
`INSERT INTO entries(event_id, category_id, team_id) VALUES (1, 1, 1)`,
|
||||
`INSERT INTO results(event_id, entry_id, rank, result_text, state) VALUES (1, 1, 1, '11.58', 'published')`,
|
||||
`INSERT INTO score_ledger(team_id, event_id, entry_id, result_id, source_type, source_id, points)
|
||||
VALUES (1, 1, 1, 1, 'result', 1, 10)`,
|
||||
`INSERT INTO point_adjustments(team_id, delta, category, reason, event_id)
|
||||
VALUES (1, 5, 'bonus', '测试', 1)`,
|
||||
`INSERT INTO records(event_id, level, holder_name) VALUES (1, 'meet', '张三')`,
|
||||
`INSERT INTO record_breaks(event_id, entry_id, level) VALUES (1, 1, 'meet')`,
|
||||
`INSERT INTO result_revisions(id, parent_id, event_id, action, snapshot_json)
|
||||
VALUES (1, NULL, 1, 'publish', '{}'), (2, 1, 1, 'edit', '{}')`,
|
||||
}
|
||||
for _, s := range stmts {
|
||||
if _, err := db.Exec(s); err != nil {
|
||||
t.Fatalf("造数据 %q: %v", s, err)
|
||||
}
|
||||
}
|
||||
|
||||
body, err := fs.ReadFile(fsys, "0012_ledger_entry_index_and_fk.sql")
|
||||
if err != nil {
|
||||
t.Fatalf("读取 0012: %v", err)
|
||||
}
|
||||
tx, err := db.Begin()
|
||||
if err != nil {
|
||||
t.Fatalf("开启事务: %v", err)
|
||||
}
|
||||
if _, err := tx.Exec(string(body)); err != nil {
|
||||
_ = tx.Rollback()
|
||||
t.Fatalf("应用 0012: %v", err)
|
||||
}
|
||||
if err := tx.Commit(); err != nil {
|
||||
t.Fatalf("提交 0012: %v", err)
|
||||
}
|
||||
|
||||
for table, want := range map[string]int{
|
||||
"score_ledger": 1, "point_adjustments": 1, "records": 1, "record_breaks": 1, "result_revisions": 2,
|
||||
} {
|
||||
if got := countRows(t, db, table); got != want {
|
||||
t.Errorf("%s 升级后行数 = %d，期望 %d", table, got, want)
|
||||
}
|
||||
}
|
||||
if got := queryInt(t, db, `SELECT count(*) FROM result_revisions WHERE parent_id = 1`); got != 1 {
|
||||
t.Errorf("result_revisions 的 parent_id 未保留，子行数 = %d", got)
|
||||
}
|
||||
if got := queryInt(t, db, `SELECT CAST(points AS INTEGER) FROM score_ledger WHERE id = 1`); got != 10 {
|
||||
t.Errorf("score_ledger 分值 = %d，期望 10", got)
|
||||
}
|
||||
}
|
||||
|
||||
func assertIndex(t *testing.T, db *sql.DB, table, index string) {
|
||||
t.Helper()
|
||||
var n int
|
||||
if err := db.QueryRow(
|
||||
`SELECT count(*) FROM sqlite_master WHERE type = 'index' AND name = ? AND tbl_name = ?`,
|
||||
index, table,
|
||||
).Scan(&n); err != nil {
|
||||
t.Fatalf("查询索引 %s: %v", index, err)
|
||||
}
|
||||
if n != 1 {
|
||||
t.Errorf("索引 %s(%s) 不存在", index, table)
|
||||
}
|
||||
}
|
||||
|
||||
func queryInt(t *testing.T, db *sql.DB, query string, args ...any) int {
|
||||
t.Helper()
|
||||
var n int
|
||||
if err := db.QueryRow(query, args...).Scan(&n); err != nil {
|
||||
t.Fatalf("查询 %q: %v", query, err)
|
||||
}
|
||||
return n
|
||||
}
|
||||
|
||||
func checkProfile(t *testing.T, db *sql.DB, code, name string, want []float64) {
|
||||
t.Helper()
|
||||
|
||||
|
||||
Reference in new issue
Block a user