fix: 修掉十路审查发现的 9 个 P0 与一批 P1(数据正确性 / 越权 / 现场可用性)
P0(9 条全修): - 多通道项目奖牌重复计数:domain 层按 (EventID,CategoryID,EntryID/Subject) 去重, 通道优先级 athlete→team→id - 「只排名不计分」项目(scored:false)不再进奖牌榜,REST/WS/导出口径统一 - aggregate 流水 entry_id 恒 NULL 导致重算后分数翻倍:作废范围改按 event+category 定位 - 已发布成绩仍可被「存草稿」覆盖并清空 rank:服务端 409 STATE_INVALID + 前端禁编辑 - voidResult / 规则导入重算后名次不回写:接住 Ranked 调 applyComputedRanks - 赛事包覆盖导入可能「旧项目已删、新项目没成」:先改名成功再清理,失败回滚 - 导入赛事包可覆盖正在运行的赛事目录:name==当前项目直接 400 - Console spawn 失败后守护器永久卡死:清 child/pid + 调度重启 + stop 超时兜底 - /ws 快照向非 admin 下发 admin-only 配置:按角色裁剪 settings P1(计分口径 / 契约 / 现场): - standings.tieBreak 三处接线;profiles[].recordBonusMode 生效;破纪录校验 RecordEligible 与 entry 归属;破纪录登记校验已发布成绩 - export.loadRanked 与主路径对齐;ListBackups reason 解析;CLI backup 前缀修正 (原来只增不减会撑爆磁盘);单位积分明细/导出统一权重折算;停用单位展示 - 规则导入原子化(重算并入同一事务)+ 返回 compatible/affectedEventCount/ recalculatedLedgerRows;登录审计 user_id 修正 - WS 策略性断开用 Close(code,reason);HelloMessage 补 page/instanceId; 实例注册表清理;settings/单位/项目写操作补 change_log 触发大屏刷新 - 大屏:全量快照不再被版本守卫丢弃;个人积分榜刷新;公告返回页/轮播;行数截断; REST 竞态;1008 停止重连;握手超时;时区补 Z;401 仅 AUTH_REQUIRED 才登出 - 管理端:published 行禁编辑;saveDraft 补 unit(1:06.33 显示);前端预览改用服务端 points;空成绩行不再恒「已修改」;修订详情按 id 拉取;切项目请求序号与 dirty 保护; 发布后刷新项目状态;NAV/路由按角色过滤;recorder 不再打 admin-only 接口 - Console:大屏窗口销毁后重建;大屏 URL 复用 host 归一化;backup.bat 改纯 ASCII (已在 Meowhome 实跑验证) 自检:服务端 gofmt/build/vet 通过、12 包测试全绿;前端 vue-tsc + build 通过、 node --test 24/24;console check-syntax 12 文件通过。
This commit is contained in:
1 parent
96cf181ae3
commit
13f1f03cd0
124 files changed
+5658
-1820
No files matched your search
@@ -0,0 +1,87 @@
|
||||
package httpapi_test
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"net/http"
|
||||
"testing"
|
||||
|
||||
"git.yeij.top/AskaEth/Scoreboard/server/internal/httpapi"
|
||||
)
|
||||
|
||||
// 单位增删改必须写 change_log,否则 broadcastChanges 推空、大屏单位名不刷新。
|
||||
func TestTeamWritesWriteChangeLogAndBroadcast(t *testing.T) {
|
||||
fake := &fakeRealtime{}
|
||||
env := newTestEnvWith(t, func(o *httpapi.Options) { o.Realtime = fake })
|
||||
fake.db = env.ev
|
||||
env.createUser("recorder", "recorder-pass", "recorder")
|
||||
client, _ := env.client()
|
||||
env.login(client, "recorder", "recorder-pass")
|
||||
|
||||
status, env2 := env.do(client, http.MethodPost, "/api/teams", map[string]any{
|
||||
"code": "C", "name": "第三分公司", "active": true,
|
||||
}, true)
|
||||
if status != http.StatusOK || !env2.OK {
|
||||
t.Fatalf("建单位应 200,得到 %d %+v", status, env2.Error)
|
||||
}
|
||||
if got := changeLogCount(t, env, "teams", "upsert"); got != 1 {
|
||||
t.Fatalf("建单位应写 1 条 teams change_log,得到 %d", got)
|
||||
}
|
||||
created := decodeData[map[string]any](t, env2)
|
||||
teamID := int64(created["id"].(float64))
|
||||
|
||||
found := false
|
||||
for _, ch := range fake.firstBatch(t) {
|
||||
if ch.Entity == "teams" && ch.Action == "upsert" && ch.ID == teamID {
|
||||
found = true
|
||||
}
|
||||
}
|
||||
if !found {
|
||||
t.Fatalf("建单位后应广播 teams 变更")
|
||||
}
|
||||
|
||||
if status, env2 = env.do(client, http.MethodDelete, fmt.Sprintf("/api/teams/%d", teamID), nil, true); status != http.StatusOK {
|
||||
t.Fatalf("删单位应 200,得到 %d %+v", status, env2.Error)
|
||||
}
|
||||
if got := changeLogCount(t, env, "teams", "void"); got != 1 {
|
||||
t.Fatalf("删单位应写 1 条 teams void 变更,得到 %d", got)
|
||||
}
|
||||
}
|
||||
|
||||
// 项目、组别、通道的写操作同样要推 change_log,大屏才会刷新。
|
||||
func TestEventWritesWriteChangeLog(t *testing.T) {
|
||||
env := newTestEnv(t)
|
||||
ids := env.seed(t)
|
||||
env.createUser("recorder", "recorder-pass", "recorder")
|
||||
client, _ := env.client()
|
||||
env.login(client, "recorder", "recorder-pass")
|
||||
|
||||
status, env2 := env.do(client, http.MethodPost, "/api/events", map[string]any{
|
||||
"sportId": ids.sport, "code": "M400", "name": "400米跑",
|
||||
"eventType": "individual", "resultType": "time", "compare": "asc", "scored": true,
|
||||
}, true)
|
||||
if status != http.StatusOK || !env2.OK {
|
||||
t.Fatalf("建项目应 200,得到 %d %+v", status, env2.Error)
|
||||
}
|
||||
if got := changeLogCount(t, env, "events", "upsert"); got != 1 {
|
||||
t.Fatalf("建项目应写 1 条 events change_log,得到 %d", got)
|
||||
}
|
||||
created := decodeData[map[string]any](t, env2)
|
||||
eventID := int64(created["id"].(float64))
|
||||
|
||||
status, env2 = env.do(client, http.MethodPut, fmt.Sprintf("/api/events/%d/categories", eventID), map[string]any{
|
||||
"categories": []map[string]any{{"name": "男子", "multiplier": 1}},
|
||||
}, true)
|
||||
if status != http.StatusOK || !env2.OK {
|
||||
t.Fatalf("替换组别应 200,得到 %d %+v", status, env2.Error)
|
||||
}
|
||||
if got := changeLogCount(t, env, "events", "upsert"); got != 2 {
|
||||
t.Fatalf("替换组别应再写 1 条 events change_log,得到 %d", got)
|
||||
}
|
||||
|
||||
if status, env2 = env.do(client, http.MethodDelete, fmt.Sprintf("/api/events/%d", eventID), nil, true); status != http.StatusOK {
|
||||
t.Fatalf("删项目应 200,得到 %d %+v", status, env2.Error)
|
||||
}
|
||||
if got := changeLogCount(t, env, "events", "void"); got != 1 {
|
||||
t.Fatalf("删项目应写 1 条 events void 变更,得到 %d", got)
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user