fix: 修掉十路审查发现的 9 个 P0 与一批 P1（数据正确性 / 越权 / 现场可用性）
P0（9 条全修）： - 多通道项目奖牌重复计数：domain 层按 (EventID,CategoryID,EntryID/Subject) 去重， 通道优先级 athlete→team→id - 「只排名不计分」项目（scored:false）不再进奖牌榜，REST/WS/导出口径统一 - aggregate 流水 entry_id 恒 NULL 导致重算后分数翻倍：作废范围改按 event+category 定位 - 已发布成绩仍可被「存草稿」覆盖并清空 rank：服务端 409 STATE_INVALID + 前端禁编辑 - voidResult / 规则导入重算后名次不回写：接住 Ranked 调 applyComputedRanks - 赛事包覆盖导入可能「旧项目已删、新项目没成」：先改名成功再清理，失败回滚 - 导入赛事包可覆盖正在运行的赛事目录：name==当前项目直接 400 - Console spawn 失败后守护器永久卡死：清 child/pid + 调度重启 + stop 超时兜底 - /ws 快照向非 admin 下发 admin-only 配置：按角色裁剪 settings P1（计分口径 / 契约 / 现场）： - standings.tieBreak 三处接线；profiles[].recordBonusMode 生效；破纪录校验 RecordEligible 与 entry 归属；破纪录登记校验已发布成绩 - export.loadRanked 与主路径对齐；ListBackups reason 解析；CLI backup 前缀修正 （原来只增不减会撑爆磁盘）；单位积分明细/导出统一权重折算；停用单位展示 - 规则导入原子化（重算并入同一事务）+ 返回 compatible/affectedEventCount/ recalculatedLedgerRows；登录审计 user_id 修正 - WS 策略性断开用 Close(code,reason)；HelloMessage 补 page/instanceId； 实例注册表清理；settings/单位/项目写操作补 change_log 触发大屏刷新 - 大屏：全量快照不再被版本守卫丢弃；个人积分榜刷新；公告返回页/轮播；行数截断； REST 竞态；1008 停止重连；握手超时；时区补 Z；401 仅 AUTH_REQUIRED 才登出 - 管理端：published 行禁编辑；saveDraft 补 unit（1:06.33 显示）；前端预览改用服务端 points；空成绩行不再恒「已修改」；修订详情按 id 拉取；切项目请求序号与 dirty 保护； 发布后刷新项目状态；NAV/路由按角色过滤；recorder 不再打 admin-only 接口 - Console：大屏窗口销毁后重建；大屏 URL 复用 host 归一化；backup.bat 改纯 ASCII （已在 Meowhome 实跑验证） 自检：服务端 gofmt/build/vet 通过、12 包测试全绿；前端 vue-tsc + build 通过、 node --test 24/24；console check-syntax 12 文件通过。
This commit is contained in:
AskaEth committed
1 parent
96cf181ae3
commit
13f1f03cd0
124 files changed
+5658
-1820
No files matched your search
@@ -131,66 +131,6 @@ func TestMatrix07_TiedFirstMedalCount(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
// case 8：发布后撤销 → 流水作废，总分回退。
|
||||
func TestMatrix08_UnpublishRevertsTotal(t *testing.T) {
|
||||
entries, results := fixture(lineup(3))
|
||||
es := mustScore(t, EventScoreInput{
|
||||
Event: individualEvent(1), Category: testCategory(),
|
||||
Channels: []ScoreChannel{athleteResultChannel(1)},
|
||||
Profiles: map[int64]ScoringProfile{1: individualTop6()},
|
||||
Entries: entries, Results: results,
|
||||
})
|
||||
|
||||
published := SumByTeam(es.Ledger, 1)
|
||||
if !nearlyEqual(published[1001].Total, 10) {
|
||||
t.Fatalf("发布后总分 = %v，期望 10", published[1001].Total)
|
||||
}
|
||||
|
||||
voided, count := VoidByEvent(es.Ledger, 1, "admin", "撤销发布")
|
||||
if count != len(es.Ledger) {
|
||||
t.Fatalf("作废条数 = %d，期望 %d", count, len(es.Ledger))
|
||||
}
|
||||
after := SumByTeam(voided, 1)
|
||||
for id, p := range after {
|
||||
if p.Total != 0 {
|
||||
t.Errorf("单位 %d 撤销后总分 = %v，期望 0", id, p.Total)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// case 9：修改已发布成绩 → 旧流水作废 + 新流水，审计可查。
|
||||
func TestMatrix09_EditPublishedResult(t *testing.T) {
|
||||
entries, results := fixture(lineup(3))
|
||||
in := EventScoreInput{
|
||||
Event: individualEvent(1), Category: testCategory(),
|
||||
Channels: []ScoreChannel{athleteResultChannel(1)},
|
||||
Profiles: map[int64]ScoringProfile{1: individualTop6()},
|
||||
Entries: entries, Results: results,
|
||||
}
|
||||
first := mustScore(t, in)
|
||||
|
||||
// 改判：entry1 变成最后一名，entry2、entry3 各前进一位。
|
||||
entries[0].ID = 1
|
||||
results[0].ResultValue = ptr(10)
|
||||
results[1].ResultValue = ptr(1)
|
||||
results[2].ResultValue = ptr(2)
|
||||
fresh := mustScore(t, in)
|
||||
|
||||
rebuilt, err := RecomputeEventLedger(first.Ledger, 1, fresh.Ledger, "judge", "成绩更正")
|
||||
if err != nil {
|
||||
t.Fatalf("重算流水失败: %v", err)
|
||||
}
|
||||
if len(rebuilt) <= len(first.Ledger) {
|
||||
t.Fatalf("重算后流水条数 = %d，期望大于 %d（旧作废 + 新追加）", len(rebuilt), len(first.Ledger))
|
||||
}
|
||||
for _, e := range rebuilt {
|
||||
if e.Voided && (e.VoidedBy != "judge" || e.VoidReason != "成绩更正") {
|
||||
t.Errorf("作废流水缺少审计信息: %+v", e)
|
||||
}
|
||||
}
|
||||
assertEntryPoints(t, pointsByEntry(rebuilt), []float64{6, 10, 8})
|
||||
}
|
||||
|
||||
// case 10：弃权者不占名次 → 名次顺延。
|
||||
func TestMatrix10_WithdrawnDoesNotOccupyRank(t *testing.T) {
|
||||
ps := lineup(5)
|
||||
@@ -230,14 +170,10 @@ func TestMatrix12_ManualPenaltyReorders(t *testing.T) {
|
||||
t.Fatalf("扣分前榜首 = 单位 %d，期望 1（同分时编码小者在前）", before[0].TeamID)
|
||||
}
|
||||
|
||||
adjustments, err := AdjustmentsToLedger(
|
||||
ManualAdjustmentConfig{Enabled: true, ReasonRequired: true},
|
||||
[]PointAdjustment{{ID: 1, TeamID: 1, Delta: -3, Category: AdjustmentPenalty, Reason: "犯规扣分"}},
|
||||
)
|
||||
if err != nil {
|
||||
t.Fatalf("人工调整转换失败: %v", err)
|
||||
}
|
||||
in.Ledger = append(in.Ledger, adjustments...)
|
||||
// 人工扣分：单位1 -3 分（本期入口关闭，这里直接构造调整流水验证榜单口径）。
|
||||
in.Ledger = append(in.Ledger, LedgerEntry{
|
||||
TeamID: 1, SourceType: SourceAdjustment, SourceID: 1, Points: -3,
|
||||
})
|
||||
|
||||
after := BuildTeamStandings(in)
|
||||
if after[0].TeamID != 2 {
|
||||
@@ -375,83 +311,3 @@ func TestMatrix16_UnionEntry(t *testing.T) {
|
||||
t.Fatalf("整体归属 = %v，期望 1001:10 / 1002:0", byTeam)
|
||||
}
|
||||
}
|
||||
|
||||
// case 17：重复发布同一组 → 幂等，不产生重复流水。
|
||||
func TestMatrix17_RepublishIdempotent(t *testing.T) {
|
||||
entries, results := fixture(lineup(3))
|
||||
in := EventScoreInput{
|
||||
Event: individualEvent(1), Category: testCategory(),
|
||||
Channels: []ScoreChannel{athleteResultChannel(1)},
|
||||
Profiles: map[int64]ScoringProfile{1: individualTop6()},
|
||||
Entries: entries, Results: results,
|
||||
}
|
||||
first := mustScore(t, in)
|
||||
second := mustScore(t, in)
|
||||
|
||||
rebuilt, err := RecomputeEventLedger(first.Ledger, 1, second.Ledger, "admin", "重复发布")
|
||||
if err != nil {
|
||||
t.Fatalf("重算流水失败: %v", err)
|
||||
}
|
||||
if len(rebuilt) != len(first.Ledger) {
|
||||
t.Fatalf("重复发布后流水条数 = %d，期望 %d（幂等）", len(rebuilt), len(first.Ledger))
|
||||
}
|
||||
before := SumByTeam(first.Ledger, 1)
|
||||
after := SumByTeam(rebuilt, 1)
|
||||
for id, p := range before {
|
||||
if !nearlyEqual(after[id].Total, p.Total) {
|
||||
t.Errorf("单位 %d 总分 = %v，期望 %v", id, after[id].Total, p.Total)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// case 18：乱序应用增量 → 最终状态一致。
|
||||
func TestMatrix18_OutOfOrderIncrements(t *testing.T) {
|
||||
makeScore := func(eventID int64) []LedgerEntry {
|
||||
entries, results := fixture([]participant{{entryID: eventID, athleteID: eventID, teamID: eventID, value: 1}})
|
||||
entries[0].EventID = eventID
|
||||
results[0].EventID = eventID
|
||||
return mustScore(t, EventScoreInput{
|
||||
Event: Event{ID: eventID, Compare: CompareAsc, Scored: true, Multiplier: 1},
|
||||
Category: testCategory(),
|
||||
Channels: []ScoreChannel{athleteResultChannel(1)},
|
||||
Profiles: map[int64]ScoringProfile{1: individualTop6()},
|
||||
Entries: entries, Results: results,
|
||||
}).Ledger
|
||||
}
|
||||
a := makeScore(11)
|
||||
b := makeScore(22)
|
||||
|
||||
appendA := LedgerOp{Kind: LedgerOpAppend, Entries: a}
|
||||
appendB := LedgerOp{Kind: LedgerOpAppend, Entries: b}
|
||||
voidA := LedgerOp{Kind: LedgerOpVoidSource, SourceType: SourceResult, SourceID: a[0].SourceID, By: "admin", Reason: "撤销"}
|
||||
|
||||
orders := map[string][]LedgerOp{
|
||||
"A→B→撤销A": {appendA, appendB, voidA},
|
||||
"B→A→撤销A": {appendB, appendA, voidA},
|
||||
"A→撤销A→B": {appendA, voidA, appendB},
|
||||
}
|
||||
|
||||
var baseline map[int64]TeamPoints
|
||||
for name, ops := range orders {
|
||||
out, err := ApplyLedgerOps(nil, ops)
|
||||
if err != nil {
|
||||
t.Fatalf("%s: %v", name, err)
|
||||
}
|
||||
got := SumByTeam(out, 1)
|
||||
if baseline == nil {
|
||||
baseline = got
|
||||
continue
|
||||
}
|
||||
if len(got) != len(baseline) {
|
||||
t.Fatalf("%s: 单位数 %d，期望 %d", name, len(got), len(baseline))
|
||||
}
|
||||
for id, p := range baseline {
|
||||
if !nearlyEqual(got[id].Total, p.Total) {
|
||||
t.Errorf("%s: 单位 %d 总分 = %v，期望 %v", name, id, got[id].Total, p.Total)
|
||||
}
|
||||
}
|
||||
}
|
||||
if !nearlyEqual(baseline[11].Total, 0) || !nearlyEqual(baseline[22].Total, 10) {
|
||||
t.Fatalf("最终状态 = %+v，期望 A 作废 0 分、B 保留 10 分", baseline)
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user