按 DevDocs/design/22 批次 1 后端(§2/§3/§4.1-4.5/§4.7/§5 验收 1-6)。
- 迁移 0011:chat_sessions.persona_id + chat_messages.persona_id(均 DEFAULT '',无回填 → 升级零风险);同步包内幂等 DDL;**真实库升级验证**(拷贝 data/cyrene.db 到临时目录跑 MigrateUp:既有 1 会话/109 消息 persona 仍为 '',原库未被触碰)
- history:SessionMeta/Message 加 PersonaID + SetSessionPersona;ListSessions/List/scan/Append 带上
- runtime:SessionEnv.PersonaID + loop.personaFor(ctx) 替换固定 l.personaID(memory/request/turn)+ **agent 池**(Options.Agents,按角色取 instructions,未命中回落)+ **提取器不再把 persona 烤死在构造期**(多角色下记忆不再永远记在 cyrene 名下)+ **thinking 旋钮改为按会话角色解析**(否则角色 Y 会用角色 X 的预算/展示)
- gateway:会话 DTO/POST/PATCH 支持 personaId;ws/rest/voice 的 OwnerEnv 硬编改为**按会话解析角色**(actor 元数据语义不变);admin memories 搜索去掉硬编 cyrene
- Docs/api-client v0.42;**两处有意的行为收紧**已写明:POST /sessions body 非法 JSON → 400(原先完全忽略 body;空/null/{} 仍 201);POST /admin/memories/search 省略 personaId 且无默认角色 → 400(原先默认查 cyrene)
- 测试:design/22 §5 验收 1-6(记忆隔离/提示词首条 system/情绪按角色/提取 persona 归属/迁移兼容)+ 进程内 e2e(断言 adapter 收到的 model.Request.Messages[0] 即该角色的 systemPrompt)
- **已知未做(留批次 2 / 待确认)**:① IM 与渠道级未做 → **§7-3「owner 私聊镜像随主会话角色」尚未生效**;② 请求级覆盖未实现(本批只做会话级);③ **§7-5 的「上下文发送角色标记」只完成存储+DTO 半边**——消息 persona 已落库且 DTO 已带,但模型上下文不从 chat_messages 重建,「第 N 条是谁说的」尚未进上下文(需确认是否属批次 2);④「切角色重建摘要」当前是空操作(压缩未接线);⑤ thinking 旋钮仅在流式路径生效(非流式 agent.RunStep 不带,A 批次既有性质)
- 验收:go build/vet/test 全绿 + linux/amd64 与 darwin/arm64 交叉编译(既有 flake 本轮未触发;同批 session_orchestrator.go 一度 501 行 → 抽出 session_tail.go)
244 lines
6.8 KiB
Go
244 lines
6.8 KiB
Go
package db
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"errors"
|
|
"slices"
|
|
"testing"
|
|
)
|
|
|
|
// openMemory opens an isolated in-memory DB for a test.
|
|
func openMemory(t *testing.T) *sql.DB {
|
|
t.Helper()
|
|
ctx := context.Background()
|
|
db, err := Open(ctx, ":memory:", testLogger())
|
|
if err != nil {
|
|
t.Fatalf("Open(:memory:) failed: %v", err)
|
|
}
|
|
t.Cleanup(func() { db.Close() })
|
|
return db
|
|
}
|
|
|
|
// registeredMigrations returns the ids currently recorded in schema_migrations.
|
|
func registeredMigrations(t *testing.T, ctx context.Context, db *sql.DB) []string {
|
|
t.Helper()
|
|
rows, err := db.QueryContext(ctx, "SELECT id FROM schema_migrations")
|
|
if err != nil {
|
|
t.Fatalf("query schema_migrations: %v", err)
|
|
}
|
|
defer rows.Close()
|
|
var ids []string
|
|
for rows.Next() {
|
|
var id string
|
|
if err := rows.Scan(&id); err != nil {
|
|
t.Fatalf("scan migration id: %v", err)
|
|
}
|
|
ids = append(ids, id)
|
|
}
|
|
if err := rows.Err(); err != nil {
|
|
t.Fatalf("iterate schema_migrations: %v", err)
|
|
}
|
|
return ids
|
|
}
|
|
|
|
// upMigrationIDs returns the ids of the embedded up-migrations in apply order.
|
|
func upMigrationIDs(t *testing.T) []string {
|
|
t.Helper()
|
|
migs, err := loadMigrations()
|
|
if err != nil {
|
|
t.Fatalf("loadMigrations: %v", err)
|
|
}
|
|
ids := make([]string, len(migs))
|
|
for i, m := range migs {
|
|
ids[i] = m.id
|
|
}
|
|
return ids
|
|
}
|
|
|
|
// appMetaExists reports whether the app_meta table is present.
|
|
func appMetaExists(t *testing.T, ctx context.Context, db *sql.DB) bool {
|
|
t.Helper()
|
|
var n int
|
|
if err := db.QueryRowContext(ctx, "SELECT count(*) FROM sqlite_master WHERE type='table' AND name='app_meta'").Scan(&n); err != nil {
|
|
t.Fatalf("check app_meta presence: %v", err)
|
|
}
|
|
return n == 1
|
|
}
|
|
|
|
func TestMigrateUp_FirstApply_正常(t *testing.T) {
|
|
t.Parallel()
|
|
ctx := context.Background()
|
|
db := openMemory(t)
|
|
|
|
if err := MigrateUp(ctx, db, testLogger()); err != nil {
|
|
t.Fatalf("MigrateUp first call: %v", err)
|
|
}
|
|
|
|
// Applies every embedded up-migration, in order.
|
|
ids := registeredMigrations(t, ctx, db)
|
|
if want := upMigrationIDs(t); !slices.Equal(ids, want) {
|
|
t.Fatalf("schema_migrations = %v, want %v", ids, want)
|
|
}
|
|
if !appMetaExists(t, ctx, db) {
|
|
t.Fatal("app_meta table should exist after MigrateUp")
|
|
}
|
|
|
|
// applied_at must be recorded on the first migration row.
|
|
var appliedAt string
|
|
if err := db.QueryRowContext(ctx, "SELECT applied_at FROM schema_migrations WHERE id = ?", "0001_init").Scan(&appliedAt); err != nil {
|
|
t.Fatalf("read applied_at: %v", err)
|
|
}
|
|
if appliedAt == "" {
|
|
t.Fatal("applied_at should not be empty")
|
|
}
|
|
}
|
|
|
|
func TestMigrateUp_Idempotent_正常(t *testing.T) {
|
|
t.Parallel()
|
|
ctx := context.Background()
|
|
db := openMemory(t)
|
|
|
|
if err := MigrateUp(ctx, db, testLogger()); err != nil {
|
|
t.Fatalf("MigrateUp first call: %v", err)
|
|
}
|
|
|
|
// Second call must not re-execute or duplicate the records.
|
|
if err := MigrateUp(ctx, db, testLogger()); err != nil {
|
|
t.Fatalf("MigrateUp second call: %v", err)
|
|
}
|
|
want := upMigrationIDs(t)
|
|
ids := registeredMigrations(t, ctx, db)
|
|
if !slices.Equal(ids, want) {
|
|
t.Fatalf("idempotent: schema_migrations = %v, want %v", ids, want)
|
|
}
|
|
if !appMetaExists(t, ctx, db) {
|
|
t.Fatal("app_meta should still exist after idempotent re-run")
|
|
}
|
|
}
|
|
|
|
func TestMigrateDown_ThenReUp_正常(t *testing.T) {
|
|
t.Parallel()
|
|
ctx := context.Background()
|
|
db := openMemory(t)
|
|
|
|
want := upMigrationIDs(t)
|
|
if err := MigrateUp(ctx, db, testLogger()); err != nil {
|
|
t.Fatalf("MigrateUp: %v", err)
|
|
}
|
|
|
|
// Roll back every applied migration.
|
|
if err := MigrateDown(ctx, db, len(want), testLogger()); err != nil {
|
|
t.Fatalf("MigrateDown(all): %v", err)
|
|
}
|
|
if appMetaExists(t, ctx, db) {
|
|
t.Fatal("app_meta should be dropped after MigrateDown(all)")
|
|
}
|
|
if ids := registeredMigrations(t, ctx, db); len(ids) != 0 {
|
|
t.Fatalf("schema_migrations should be empty after rollback, got %v", ids)
|
|
}
|
|
|
|
// Re-applying must work end to end again.
|
|
if err := MigrateUp(ctx, db, testLogger()); err != nil {
|
|
t.Fatalf("re-MigrateUp: %v", err)
|
|
}
|
|
if !appMetaExists(t, ctx, db) {
|
|
t.Fatal("app_meta should exist again after re-MigrateUp")
|
|
}
|
|
if ids := registeredMigrations(t, ctx, db); !slices.Equal(ids, want) {
|
|
t.Fatalf("schema_migrations = %v, want %v", ids, want)
|
|
}
|
|
}
|
|
|
|
func TestMigrateDown_ZeroSteps_异常(t *testing.T) {
|
|
t.Parallel()
|
|
ctx := context.Background()
|
|
db := openMemory(t)
|
|
|
|
if err := MigrateUp(ctx, db, testLogger()); err != nil {
|
|
t.Fatalf("MigrateUp: %v", err)
|
|
}
|
|
|
|
for _, steps := range []int{0, -1} {
|
|
if err := MigrateDown(ctx, db, steps, testLogger()); !errors.Is(err, ErrInvalidSteps) {
|
|
t.Fatalf("MigrateDown(%d) err = %v, want wrap of ErrInvalidSteps", steps, err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestMigrateDown_StepsBeyondApplied_边界(t *testing.T) {
|
|
t.Parallel()
|
|
ctx := context.Background()
|
|
db := openMemory(t)
|
|
|
|
if err := MigrateUp(ctx, db, testLogger()); err != nil {
|
|
t.Fatalf("MigrateUp: %v", err)
|
|
}
|
|
|
|
// More steps than applied must roll everything back without error. The count is
|
|
// derived from the embedded migration set rather than hardcoded, so adding a
|
|
// migration cannot silently leave the oldest one applied.
|
|
if err := MigrateDown(ctx, db, len(upMigrationIDs(t))+1, testLogger()); err != nil {
|
|
t.Fatalf("MigrateDown(all+1): %v", err)
|
|
}
|
|
if appMetaExists(t, ctx, db) {
|
|
t.Fatal("app_meta should be dropped when rolling back all")
|
|
}
|
|
if ids := registeredMigrations(t, ctx, db); len(ids) != 0 {
|
|
t.Fatalf("schema_migrations should be empty, got %v", ids)
|
|
}
|
|
}
|
|
|
|
func TestAppMeta_ReadWrite_正常(t *testing.T) {
|
|
t.Parallel()
|
|
ctx := context.Background()
|
|
db := openMemory(t)
|
|
|
|
if err := MigrateUp(ctx, db, testLogger()); err != nil {
|
|
t.Fatalf("MigrateUp: %v", err)
|
|
}
|
|
|
|
// Parameterized insert.
|
|
if _, err := db.ExecContext(ctx,
|
|
"INSERT INTO app_meta (key, value) VALUES (?, ?)", "schema_version", "1"); err != nil {
|
|
t.Fatalf("insert app_meta: %v", err)
|
|
}
|
|
|
|
// Parameterized read.
|
|
var value string
|
|
if err := db.QueryRowContext(ctx,
|
|
"SELECT value FROM app_meta WHERE key = ?", "schema_version").Scan(&value); err != nil {
|
|
t.Fatalf("read app_meta: %v", err)
|
|
}
|
|
if value != "1" {
|
|
t.Fatalf("value = %q, want %q", value, "1")
|
|
}
|
|
|
|
// Parameterized update.
|
|
if _, err := db.ExecContext(ctx,
|
|
"UPDATE app_meta SET value = ? WHERE key = ?", "2", "schema_version"); err != nil {
|
|
t.Fatalf("update app_meta: %v", err)
|
|
}
|
|
if err := db.QueryRowContext(ctx,
|
|
"SELECT value FROM app_meta WHERE key = ?", "schema_version").Scan(&value); err != nil {
|
|
t.Fatalf("read updated app_meta: %v", err)
|
|
}
|
|
if value != "2" {
|
|
t.Fatalf("value after update = %q, want %q", value, "2")
|
|
}
|
|
|
|
// Parameterized delete.
|
|
if _, err := db.ExecContext(ctx,
|
|
"DELETE FROM app_meta WHERE key = ?", "schema_version"); err != nil {
|
|
t.Fatalf("delete app_meta: %v", err)
|
|
}
|
|
var n int
|
|
if err := db.QueryRowContext(ctx,
|
|
"SELECT count(*) FROM app_meta WHERE key = ?", "schema_version").Scan(&n); err != nil {
|
|
t.Fatalf("count app_meta after delete: %v", err)
|
|
}
|
|
if n != 0 {
|
|
t.Fatalf("expected 0 rows after delete, got %d", n)
|
|
}
|
|
}
|