package memory import ( "context" "strings" "testing" "time" ) // 本文件是同步入库闸(preinsert_gate.go)的两项**旁证**,与主用例集 // (preinsert_gate_test.go 的九条)分开: // // - **真包含**(新 ⊆ 既有 ⇒ merge;既有 ⊆ 新 ⇒ modify):任务书规格 3 的表格 // 只写了三态,但确定性判据实际有 skip/merge/modify 三种命中形态,而 // merge 与 modify 落的是**不同的两笔写**(前者新行落 merged + 存活行加登记, // 后者新行存活 + 旧行置为被合并)。这两条路径必须各自被钉住,且都要能 revert。 // - **审计口径**:闸的审计**只带决定与 id,绝不带记忆正文**(design §15 D3-8)。 // TestIngestGate_真包含_merge与modify各自落对 覆盖确定性判据命中的另两种形态。 // 候选由测试直接注入,因此这条测的是**判定与落库**,不是召回。 func TestIngestGate_真包含_merge与modify各自落对(t *testing.T) { for _, tc := range []struct { name string existing string incoming string want IngestDecision newActive bool }{ {"新条是子集 ⇒ merge(既有行存活)", fixtureHabitLong, fixtureHabitShort, IngestMerge, false}, {"既有是子集 ⇒ modify(新行存活、旧行被合并)", fixtureHabitShort, fixtureHabitLong, IngestModify, true}, } { t.Run(tc.name, func(t *testing.T) { t.Parallel() ctx := context.Background() store := newTestStore(t) base := tidyTestTime(t) var existing MemoryItem r := newGateReviewer(t, store, ReviewConfig{}, func(context.Context, tidyPartition, string, int) ([]MemoryItem, error) { if existing.ID == "" { return nil, nil } return []MemoryItem{existing}, nil }) store.AttachIngestReviewer(r) existing = seedTidyItem(t, store, gateFixtureItem(tc.existing, base)) incoming := seedTidyItem(t, store, gateFixtureItem(tc.incoming, base.Add(time.Minute))) if rev := gateRecordFor(t, store, incoming.ID); rev.Decision != tc.want { t.Fatalf("闸判定 = %q, want %q", rev.Decision, tc.want) } // active 计数恒为 1:合并与改写都不该让 active 集合多出或少掉一条。 if n := countActiveRows(t, store, "persona.a"); n != 1 { t.Fatalf("active 计数 = %d, want 1", n) } survivorID, absorbedID := existing.ID, incoming.ID if tc.newActive { survivorID, absorbedID = incoming.ID, existing.ID } if got := readReviewRow(t, store, survivorID); got.status != tidyStatusActive || got.mergeCount != 2 { t.Fatalf("存活行 = %+v, want active 且 merge_count=2", got) } absorbed := readReviewRow(t, store, absorbedID) if absorbed.status != ingestStatusMerged || absorbed.mergedInto != survivorID { t.Fatalf("被吸收行 = %+v, want merged 进 %s", absorbed, survivorID) } // 正文一个字不改(design §8 的可回滚口径)。 wantContent := tc.incoming if tc.newActive { wantContent = tc.existing } if absorbed.content != wantContent { t.Fatalf("被吸收行正文 = %q, want %q", absorbed.content, wantContent) } // modify 走的是一笔**独立**的写(把旧行置为被合并),因此这里额外验 // 它同样可 revert。 if tc.newActive { if err := store.RevertMerged(ctx, absorbedID); err != nil { t.Fatalf("RevertMerged: %v", err) } restored := readReviewRow(t, store, absorbedID) if restored.status != tidyStatusActive || restored.mergedInto != "" || restored.content != wantContent { t.Fatalf("revert 后 = %+v, want active 且原文无损", restored) } if n := countActiveRows(t, store, "persona.a"); n != 2 { t.Fatalf("revert 后 active 计数 = %d, want 2", n) } } }) } } // TestIngestGate_审计只带决定不带正文 钉住闸的审计口径(design §15 D3-8): // 动作名是 memory.ingest.gate(与异步审查的 memory.review.ingest 可分), // 内容里**绝不出现记忆正文**。 func TestIngestGate_审计只带决定不带正文(t *testing.T) { t.Parallel() store := newTestStore(t) base := tidyTestTime(t) var calls []string r, err := NewPreInsertReviewer(ReviewConfig{ Enabled: true, QueueSize: 8, ScanLimit: 50, Timeout: 5 * time.Second, Threshold: 0.80, }, ReviewDeps{ Store: store, Log: testLogger(), Audit: func(who, what, result string) { calls = append(calls, who+"|"+what+"|"+result) }, }) if err != nil { t.Fatalf("NewPreInsertReviewer: %v", err) } store.AttachIngestReviewer(r) seedTidyItem(t, store, gateFixtureItem(fixtureHabitShort, base)) dup := seedTidyItem(t, store, gateFixtureItem(fixtureHabitShort, base.Add(time.Minute))) if len(calls) != 1 { t.Fatalf("审计条数 = %d (%v), want 恰为一条(闸做过决定的那一条)", len(calls), calls) } got := calls[0] if !strings.HasPrefix(got, reviewAuditWho+"|"+gateAuditVerb+"|") { t.Fatalf("审计口径 = %q, want %s|%s|…", got, reviewAuditWho, gateAuditVerb) } if !strings.Contains(got, "decision=skip") || !strings.Contains(got, "item="+dup.ID) { t.Fatalf("审计缺决定/命中 id:%q", got) } if strings.Contains(got, fixtureHabitShort) { t.Fatalf("审计带了记忆正文:%q", got) } }