test(channelbridge): 窗口夹具按截止时刻推钟 + 去掉无法证实的替身锁(M33 r1 复审)
P1-1(channelbridge 的 -race 门仍红,红在用例不确定性而不是竞态): - coalesceTimers 改成**截止时刻**语义:每次 after(d) 记 at = 注入时钟 + d, 推钟只把时钟推进到「当前最早的截止时刻」再触发它。旧写法按 FIFO 逐个触发并 按请求时长累加,实测 12 条消息内攒到 5 个废弃定时器把时钟推 +10s(窗口 2s、 绝对上限 6s)⇒ 循环头走「到点直接发车、不 takeAll」的分支,队列尾部落到下一批。 - 推钟前强制「车道排空」这条不变量(pump/advanceAndFire/waitIdle): 时钟只表示时间过去,它一转就可能跳过 takeAll,因此先等 worker 把货收进本批。 - sendSettled:投递后按**序号**等「这次投递之后新挂的定时器」(旧的都已被 worker 放弃、再没人监听),供「投递与推钟交替」的用例(每 500ms 一条的绝对上限用例)。 - fireLatest/advanceAndFire 带 done 谓词重试,避免「登记与触发之间续臂」导致 推了钟却没人醒;waitIdle 一边等一边推窗口(worker 停在窗口里时永远走不到退休)。 - 用例侧只补相位与等待,不动断言:TwelveBurst 读历史前等 assistant 行落库; 准入用例断言「最新一次续臂」(原来按下标取 d[1],隐含臂数假设); stale 用例两条都投完再推时钟(车道不会在两条之间退休)。 P2-1(替身锁无法用变异证实)选 A:删掉 stubChatter/stubSessions 的锁与访问器, 退回原字段访问,并写清理由 —— 21 个用例全走同步便捷路径 (b.process → processFrom → runBatch → Loop.Run),DEV HEAD 上 -race 数十次跑 (含把锁删掉的变异)DATA RACE 恒为 0;若将来从车道 worker 触碰这些字段必须加锁 并补 -race 用例。 证据:go test -race -count=3 ./internal/services/channelbridge/ 连跑 6 轮 18/18 全绿、DATA RACE=0;coalesce 子集 -count=80 全绿;整包 -race -count=20 全绿; 全树 go build/vet/test -count=1 全绿。
This commit is contained in:
1 parent
7d9b2132bb
commit
1ae9158250
20 files changed
+584
-371
No files matched your search
@@ -102,8 +102,8 @@ func TestColdShoulderPrecedesAddressedToMe(t *testing.T) {
|
||||
|
||||
b.process(context.Background(), coldShoulderMention("减少文本输出量"))
|
||||
|
||||
if chat.SessionID() != "" {
|
||||
t.Fatalf("循环被驱动 = %q, want \"\"(冷避必须先于 @她必回)", chat.SessionID())
|
||||
if chat.sessionID != "" {
|
||||
t.Fatalf("循环被驱动 = %q, want \"\"(冷避必须先于 @她必回)", chat.sessionID)
|
||||
}
|
||||
recs := hist.records()
|
||||
if len(recs) != 1 || recs[0].Content != "减少文本输出量" {
|
||||
@@ -137,21 +137,21 @@ func TestColdShoulderSecondReportedPhraseAndCooldownWindow(t *testing.T) {
|
||||
}
|
||||
|
||||
b.process(context.Background(), coldShoulderMention("在本群中文本输出调到最少"))
|
||||
if chat.SessionID() != "" {
|
||||
t.Fatalf("原话②之后循环被驱动 = %q, want \"\"", chat.SessionID())
|
||||
if chat.sessionID != "" {
|
||||
t.Fatalf("原话②之后循环被驱动 = %q, want \"\"", chat.sessionID)
|
||||
}
|
||||
|
||||
// 冷却期内:普通 @她 也不回(冷避优先于「@她必回」)。
|
||||
b.process(context.Background(), coldShoulderMention("晚上有空吗"))
|
||||
if chat.SessionID() != "" {
|
||||
t.Fatalf("冷却期内 @她 被驱动 = %q, want \"\"(@ 不得作废冷避)", chat.SessionID())
|
||||
if chat.sessionID != "" {
|
||||
t.Fatalf("冷却期内 @她 被驱动 = %q, want \"\"(@ 不得作废冷避)", chat.sessionID)
|
||||
}
|
||||
|
||||
// 推过默认冷却时长(30 分钟):她恢复到「@她必回」的常态。
|
||||
now = now.Add(defaultCooldownDuration + time.Minute)
|
||||
b.process(context.Background(), coldShoulderMention("晚上有空吗"))
|
||||
if chat.SessionID() != "sess-g" {
|
||||
t.Fatalf("冷却过期后 @她 仍未回:session = %q, want sess-g(冷避是**有时限**的)", chat.SessionID())
|
||||
if chat.sessionID != "sess-g" {
|
||||
t.Fatalf("冷却过期后 @她 仍未回:session = %q, want sess-g(冷避是**有时限**的)", chat.sessionID)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -172,15 +172,15 @@ func TestColdShoulderNormalMentionNotCooled(t *testing.T) {
|
||||
}
|
||||
|
||||
b.process(context.Background(), coldShoulderMention("晚上有空吗"))
|
||||
if chat.SessionID() != "sess-g" {
|
||||
t.Fatalf("普通 @她 被拦下了:session = %q, want sess-g", chat.SessionID())
|
||||
if chat.sessionID != "sess-g" {
|
||||
t.Fatalf("普通 @她 被拦下了:session = %q, want sess-g", chat.sessionID)
|
||||
}
|
||||
|
||||
// 第二条紧接着的普通 @她:若第一条被误判成负面态度,这条会落进冷却而静默。
|
||||
chat.clearSessionID()
|
||||
chat.sessionID = ""
|
||||
b.process(context.Background(), coldShoulderMention("在不在"))
|
||||
if chat.SessionID() != "sess-g" {
|
||||
t.Fatalf("第二条普通 @她 未回:session = %q(首条被误冷却了吗)", chat.SessionID())
|
||||
if chat.sessionID != "sess-g" {
|
||||
t.Fatalf("第二条普通 @她 未回:session = %q(首条被误冷却了吗)", chat.sessionID)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -214,8 +214,8 @@ func TestColdShoulderGroupOnlyBoundaries(t *testing.T) {
|
||||
Content: "闭嘴", ContentType: adapter.ContentText,
|
||||
})
|
||||
|
||||
if chat.SessionID() != "sess-p" {
|
||||
t.Fatalf("陌生人私聊被冷避拦下:session = %q, want sess-p(冷避是群机制)", chat.SessionID())
|
||||
if chat.sessionID != "sess-p" {
|
||||
t.Fatalf("陌生人私聊被冷避拦下:session = %q, want sess-p(冷避是群机制)", chat.sessionID)
|
||||
}
|
||||
})
|
||||
|
||||
@@ -237,8 +237,8 @@ func TestColdShoulderGroupOnlyBoundaries(t *testing.T) {
|
||||
m.Content = "闭嘴"
|
||||
b.process(context.Background(), m)
|
||||
|
||||
if chat.SessionID() != history.MainSessionID {
|
||||
t.Fatalf("主人私聊被冷避拦下:session = %q, want %q", chat.SessionID(), history.MainSessionID)
|
||||
if chat.sessionID != history.MainSessionID {
|
||||
t.Fatalf("主人私聊被冷避拦下:session = %q, want %q", chat.sessionID, history.MainSessionID)
|
||||
}
|
||||
})
|
||||
|
||||
@@ -251,8 +251,8 @@ func TestColdShoulderGroupOnlyBoundaries(t *testing.T) {
|
||||
|
||||
b.process(context.Background(), ownerLaneGroupMsg("安静点", adapter.Mention{UserID: "10001"}))
|
||||
|
||||
if chat.SessionID() != "sess-og" {
|
||||
t.Fatalf("主人群 @她 被冷避拦下:session = %q, want sess-og(owner 车道不受冷避影响)", chat.SessionID())
|
||||
if chat.sessionID != "sess-og" {
|
||||
t.Fatalf("主人群 @她 被冷避拦下:session = %q, want sess-og(owner 车道不受冷避影响)", chat.sessionID)
|
||||
}
|
||||
})
|
||||
}
|
||||
@@ -279,8 +279,8 @@ func TestColdShoulderSilencedMessageStillEntersContext(t *testing.T) {
|
||||
}
|
||||
|
||||
b.process(context.Background(), coldShoulderMention("减少文本输出量"))
|
||||
if chat.SessionID() != "" {
|
||||
t.Fatalf("循环被驱动 = %q, want \"\"", chat.SessionID())
|
||||
if chat.sessionID != "" {
|
||||
t.Fatalf("循环被驱动 = %q, want \"\"", chat.sessionID)
|
||||
}
|
||||
|
||||
// ① 静默那条已被登记(不是被丢掉)。
|
||||
@@ -297,11 +297,11 @@ func TestColdShoulderSilencedMessageStillEntersContext(t *testing.T) {
|
||||
// ② 冷却过期后 @她 驱动回合 → 该回合上下文里读得到那条被静默的话。
|
||||
now = now.Add(defaultCooldownDuration + time.Minute)
|
||||
b.process(context.Background(), coldShoulderMention("在吗"))
|
||||
if chat.SessionID() != "sess-g" {
|
||||
t.Fatalf("冷却过期后 @她 未驱动回合:session = %q", chat.SessionID())
|
||||
if chat.sessionID != "sess-g" {
|
||||
t.Fatalf("冷却过期后 @她 未驱动回合:session = %q", chat.sessionID)
|
||||
}
|
||||
if !loopMessagesContain(chat.Messages(), "减少文本输出量") {
|
||||
t.Fatalf("被静默登记的消息没进上下文:%+v", chat.Messages())
|
||||
if !loopMessagesContain(chat.messages, "减少文本输出量") {
|
||||
t.Fatalf("被静默登记的消息没进上下文:%+v", chat.messages)
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user